Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GreaterThan constraints #77

Merged
merged 8 commits into from
Mar 14, 2021
Merged

Handle GreaterThan constraints #77

merged 8 commits into from
Mar 14, 2021

Conversation

akshay326
Copy link
Collaborator

closes #14

@akshay326
Copy link
Collaborator Author

akshay326 commented Mar 3, 2021 •
edited
Loading

we'll need to handle Nonpositive cones in MOSD too
MOSD already supports them ✌️

@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #77 (fb3c28f) into master (d4c5093) will increase coverage by 1.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   86.18%   87.68%   +1.49%     
==========================================
  Files           4        4              
  Lines         391      414      +23     
==========================================
+ Hits          337      363      +26     
+ Misses         54       51       -3
Impacted Files Coverage Δ
src/MOI_wrapper.jl 86.08% <100.00%> (+0.15%) ⬆️
src/utils.jl 87.25% <100.00%> (+6.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c5093...fb3c28f. Read the comment docs.

matbesancon
matbesancon reviewed Mar 3, 2021
View reviewed changes
test/MOI_wrapper.jl Outdated Show resolved Hide resolved
@matbesancon
Copy link
Collaborator

We should probably have a bunch more tests with SAF in <=, >= and SV in both too to avoid bad surprises later

matbesancon
matbesancon reviewed Mar 10, 2021
View reviewed changes
src/MOI_wrapper.jl Outdated Show resolved Hide resolved
matbesancon
matbesancon reviewed Mar 10, 2021
View reviewed changes
test/MOI_wrapper.jl Outdated Show resolved Hide resolved
matbesancon
matbesancon reviewed Mar 10, 2021
View reviewed changes
test/MOI_wrapper.jl Outdated Show resolved Hide resolved
matbesancon
matbesancon reviewed Mar 10, 2021
View reviewed changes
src/MOI_wrapper.jl Outdated Show resolved Hide resolved
matbesancon
matbesancon reviewed Mar 10, 2021
View reviewed changes
src/MOI_wrapper.jl Outdated Show resolved Hide resolved
@joaquimg
Copy link
Member

Anything stopping the merge?

@matbesancon matbesancon merged commit 5eceaaf into master Mar 14, 2021
@matbesancon
Copy link
Collaborator

nope all good!

@matbesancon matbesancon deleted the handle_ge_constraints branch March 14, 2021 09:20
@joaquimg
Copy link
Member

Nice!

@akshay326 akshay326 mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbesancon matbesancon matbesancon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle GreaterThan constraints
3 participants
@akshay326 @matbesancon @joaquimg