-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #7 #8
fix #7 #8
Conversation
@tkelman to the rescue :D The verbosity of the solver is a compile-time thing so that might explain the reduced test output - the tests are pretty decent so if they pass, it works. I was expecting you, if anything, to say that Win32 segfaults, because its only been used/tested on 64-bit linux and OSX so far! |
It really is great that Win32 works though. |
One Win64 positive: the call to ECOS_ver at the start of |
Kind of a drive-by, I saw Michael Grant posting on julia-users and was wondering what was up with CVX since the Stanford guys never followed up on my standing offer to do this. I think the problem is more likely in upstream ECOS (see tons of warnings here https://gist.github.com/ced0bf8e2f0716472438, and the 64-bit |
Yes we also saw that, haven't heard from CVX.jl people lately and not really sure what the development plan is. Assume he knows about what they've done and isn't doing an independent port. In the meantime, always good to have more solvers + have the conic interface ready for a CVX-style package to use. |
Hey, sorry to hijack this thread a little bit: I saw mention of Michael Grant and CVX. I can probably surface some of your concerns / issues to him if you let me know what they are. As in, what do you @tkelman mean, "What's up with CVX?" |
Maybe Iain's thoughts are different than mine, but in my case it was more like a "oh cool good to see him using Julia and asking questions." And I met Madeleine, Karanveer, and the rest of the CVX.jl group a few months ago at a Bay Area Julia Users meetup, and offered to help out with Windows binaries. But we haven't seen much activity since the end of the semester, which is maybe not so surprising. |
Oh, okay. :-p Well, Madeleine is sharing an office with me (she's in SF today), but I'll On Thu, Jul 31, 2014 at 10:32 AM, Tony Kelman notifications@github.com
|
@tkelman: @karanveerm has been handling the windows integration issues; i'm not sure of the status, but it would be great to get your help! |
I think the Julia wrappers are okay at this point. The C tests of ECOS itself have some trouble too on Win64, we're tracking that at embotech/ecos#68. Although it makes me wonder whether it has worked correctly with Windows 64-bit via Python or Matlab yet. |
We could just merge this for now and get it out there for everyone not using Julia Win64 I suppose... |
Since apparently the wrappers are ok and this is a problem in ECOS, I agree with @IainNZ that we could merge this. As soon as they get it fixed, hopefully we will just need to update the |
Okay by me. Someone (probably me? could also be cross-compiled and should come out the same) will have to build and upload new Windows binaries once the issue is fixed upstream, then we'll know for sure whether the Julia code here needs any changes for Win64. |
OK, pulling trigger. |
As I suspected it's an integer size problem. |
fixes #7
32 bit https://ci.appveyor.com/project/tkelman/ecos-jl/build/1.0.3/job/owy7fobin6qaslc3
64 bit https://ci.appveyor.com/project/tkelman/ecos-jl/build/1.0.3/job/vnfxkgon65el7mn9
I see quite a bit more test output on a Linux machine than I do on Win32, but the tests apparently aren't flagging any errors? And Win64 segfaults. Smells like an integer size problem, either in the Julia bindings or in ECOS itself.