Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HiGHS v1.2.0 #81

Merged
merged 6 commits into from
Feb 14, 2022
Merged

Update to HiGHS v1.2.0 #81

merged 6 commits into from
Feb 14, 2022

Conversation

odow
Copy link
Member

@odow odow commented Feb 8, 2022

Closes #70
Closes #73
Closes #80

@odow
Copy link
Member Author

odow commented Feb 9, 2022

@lgottwald @jajhall looks like there are some segfaults in presolve somewhere: https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true

signal (11): Segmentation fault
[152](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:152)
in expression starting at /home/runner/work/HiGHS.jl/HiGHS.jl/test/MOI_wrapper.jl:243
[153](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:153)
_ZN8presolve9HPresolve4linkEi at /home/runner/.julia/artifacts/b35ce16fd0665f735f8c25e9b0c5ca2209d78208/lib/libhighs.so (unknown line)
[154](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:154)
_ZN8presolve9HPresolve7fromCSCERKSt6vectorIdSaIdEERKS1_IiSaIiEES9_ at /home/runner/.julia/artifacts/b35ce16fd0665f735f8c25e9b0c5ca2209d78208/lib/libhighs.so (unknown line)
[155](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:155)
_ZN8presolve9HPresolve8setInputER7HighsLpRK12HighsOptionsP10HighsTimer at /home/runner/.julia/artifacts/b35ce16fd0665f735f8c25e9b0c5ca2209d78208/lib/libhighs.so (unknown line)
[156](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:156)
_ZN17PresolveComponent3runEv at /home/runner/.julia/artifacts/b35ce16fd0665f735f8c25e9b0c5ca2209d78208/lib/libhighs.so (unknown line)
[157](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:157)
_ZN5Highs11runPresolveEv at /home/runner/.julia/artifacts/b35ce16fd0665f735f8c25e9b0c5ca2209d78208/lib/libhighs.so (unknown line)
[158](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:158)
_ZN5Highs3runEv at /home/runner/.julia/artifacts/b35ce16fd0665f735f8c25e9b0c5ca2209d78208/lib/libhighs.so (unknown line)
[159](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:159)
Highs_run at /home/runner/work/HiGHS.jl/HiGHS.jl/src/gen/libhighs.jl:47 [inlined]
[160](https://github.com/jump-dev/HiGHS.jl/runs/5117936095?check_suite_focus=true#step:6:160)
optimize! at /home/runner/work/HiGHS.jl/HiGHS.jl/src/MOI_wrapper.jl:1562

I'll work to exclude the failing tests and then build some reproducible examples.

@jajhall
Copy link

jajhall commented Feb 9, 2022

Bummer! Good job I've not advertised v1.2.0 directly to users. Rome wasn't built in a day...

@odow
Copy link
Member Author

odow commented Feb 9, 2022

This seems to be the underlying issue: ERGO-Code/HiGHS#717

A lot of JuMP tests (and users) have a work-flow that looks like add variables -> constraints -> more variables -> more constraints.

@jajhall
Copy link

jajhall commented Feb 9, 2022

Thanks. I'll create a HiGHS unit test for this and get it fixed today.

@odow odow closed this Feb 13, 2022
@odow odow reopened this Feb 13, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #81 (1d89901) into master (221489a) will decrease coverage by 1.03%.
The diff coverage is 89.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   82.65%   81.61%   -1.04%     
==========================================
  Files           2        3       +1     
  Lines        1199     1213      +14     
==========================================
- Hits          991      990       -1     
- Misses        208      223      +15     
Impacted Files Coverage Δ
src/gen/libhighs.jl 34.74% <ø> (ø)
src/MOI_wrapper.jl 92.91% <88.88%> (-1.48%) ⬇️
src/HiGHS.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221489a...1d89901. Read the comment docs.

@odow
Copy link
Member Author

odow commented Feb 14, 2022

@jajhall I updated the binaries to ERGO-Code/HiGHS@f73254c and things look great.

We're passing all the JuMP tests on Windows, Mac, and Linux, on 64-bit and 32-bit, and we're testing the simplex and IPM solvers with and without presolve.

@jajhall
Copy link

jajhall commented Feb 14, 2022

How about MIP?

@odow
Copy link
Member Author

odow commented Feb 14, 2022

Yes, all the MIP problems are passing as well

@odow
Copy link
Member Author

odow commented Feb 14, 2022

Actually I found one issue, but it's a compilation problem, not a correctness blocker: ERGO-Code/HiGHS#734

@odow odow merged commit 129bfe4 into master Feb 14, 2022
@odow odow deleted the od/v1.2 branch February 14, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update to HiGHS v1.2.0 Error when nonzero coefficient close to zero Crash when loading problem from JuMP
2 participants