Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add section on extension compatibility #3009

Merged
merged 1 commit into from
Jun 27, 2022
Merged

[docs] add section on extension compatibility #3009

merged 1 commit into from
Jun 27, 2022

Conversation

odow
Copy link
Member

@odow odow commented Jun 24, 2022

As discussed on today's developer call, extensions using the private API must use appropriate compat bounds.

x-ref: #2955

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3009 (eb6ee6e) into master (9890bb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3009   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          43       43           
  Lines        5831     5831           
=======================================
  Hits         5566     5566           
  Misses        265      265           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9890bb2...eb6ee6e. Read the comment docs.

@mlubin
Copy link
Member

mlubin commented Jun 24, 2022

Longer term it would be nice to have automatic issues/PRs to update extensions' compatibility with JuMP. Bumping the compat for every patch release is a lot of manual work.

@odow
Copy link
Member Author

odow commented Jun 24, 2022

I guess that's what https://github.com/JuliaRegistries/CompatHelper.jl is?

@odow
Copy link
Member Author

odow commented Jun 27, 2022

Merging for now. Let's see how we go, and if it is a problem we can add the suggestion for CompatHelper.jl, or consider other options.

@odow odow merged commit 1bb9d45 into master Jun 27, 2022
@odow odow deleted the od/ext-compat branch June 27, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants