Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty sums in Aff/QuadExpr parse_expression #3091

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

odow
Copy link
Member

@odow odow commented Sep 27, 2022

Closes #3090

Now produces

julia> model = Model();

julia> @variable(model, x);

julia> @expression(model, expr, x^2);

julia> @NLconstraint(model, expr >= 3)
x * x - 3.0  0

@odow odow added Type: Bug Category: Nonlinear Related to nonlinear programming labels Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 97.62% // Head: 97.63% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ae34a75) compared to base (4e276d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3091   +/-   ##
=======================================
  Coverage   97.62%   97.63%           
=======================================
  Files          32       32           
  Lines        4303     4318   +15     
=======================================
+ Hits         4201     4216   +15     
  Misses        102      102           
Impacted Files Coverage Δ
src/nlp.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit 2a587d0 into master Sep 28, 2022
@odow odow deleted the od/fix-empty-nlp branch September 28, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Nonlinear Related to nonlinear programming Type: Bug
Development

Successfully merging this pull request may close these issues.

QuadExpr in nonlinear expressions produce empty summations
1 participant