-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve printing of symmetric matrices when used in constraints #3768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3768 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 44 44
Lines 5879 5885 +6
=======================================
+ Hits 5784 5790 +6
Misses 95 95 ☔ View full report in Codecov by Sentry. |
What about some other options: julia> c = @constraint(model, x == 0)
[x[1,1] x[1,2] x[1,3] x[1,4]
↙ x[2,2] x[2,3] x[2,4]
↙ ↙ x[3,3] x[3,4]
↙ ↙ ↙ x[4,4]] ∈ Zeros()
julia> c = @constraint(model, x == 0)
[x[1,1] x[1,2] x[1,3] x[1,4]
∘ x[2,2] x[2,3] x[2,4]
∘ ∘ x[3,3] x[3,4]
∘ ∘ ∘ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⋰ x[2,2] x[2,3] x[2,4]
⋰ ⋰ x[3,3] x[3,4]
⋰ ⋰ ⋰ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⤯ x[2,2] x[2,3] x[2,4]
⤯ ⤯ x[3,3] x[3,4]
⤯ ⤯ ⤯ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⦸ x[2,2] x[2,3] x[2,4]
⦸ ⦸ x[3,3] x[3,4]
⦸ ⦸ ⦸ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⇗ x[2,2] x[2,3] x[2,4]
⇗ ⇗ x[3,3] x[3,4]
⇗ ⇗ ⇗ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⋯ x[2,2] x[2,3] x[2,4]
⋯ ⋯ x[3,3] x[3,4]
⋯ ⋯ ⋯ x[4,4]] ∈ Zeros() |
Use of It hints at "something else is here" and avoids confusion with |
Merging because I think this is a win, and it is needed for #3766 |
Closes #3764
So there is an argument for this, especially if we merge #3766, because it will help distinguish when JuMP exploits symmetry.