Fix MOA with local solvers not supporting delete #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 95.89% // Head: 95.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 95.89% 95.81% -0.09%
==========================================
Files 8 8
Lines 731 740 +9
==========================================
+ Hits 701 709 +8
- Misses 30 31 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
odow
added a commit
to jump-dev/MathOptInterface.jl
that referenced
this pull request
Feb 22, 2023
This is useful when creating optimizers which do not support the incremental interface, or which only partially implement it. This change is motivated by some recent examples in which it was necessary for the user to hard-code the caching logic to work-around the lack of deletion in a solver, and the caching logic is confusing to even advanced users. See: * https://discourse.julialang.org/t/jump-scip-error/93958 * jump-dev/MultiObjectiveAlgorithms.jl#46
odow
added a commit
to jump-dev/MathOptInterface.jl
that referenced
this pull request
Feb 24, 2023
This is useful when creating optimizers which do not support the incremental interface, or which only partially implement it. This change is motivated by some recent examples in which it was necessary for the user to hard-code the caching logic to work-around the lack of deletion in a solver, and the caching logic is confusing to even advanced users. See: * https://discourse.julialang.org/t/jump-scip-error/93958 * jump-dev/MultiObjectiveAlgorithms.jl#46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
This also fixes a bunch of cases which assume
MOI.OPTIMALis the only status that may be returned.