Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpful error instead of segfault for empty model #122

Closed
blegat opened this issue Nov 7, 2018 · 2 comments · Fixed by #123
Closed

Helpful error instead of segfault for empty model #122

blegat opened this issue Nov 7, 2018 · 2 comments · Fixed by #123

Comments

@blegat
Copy link
Member

blegat commented Nov 7, 2018

With an empty model, SCS segfaults. Instead it should throw an helpful error.
See jump-dev/JuMP.jl#1502
@blegat blegat mentioned this issue Nov 7, 2018
Closed
@kalmarek
Copy link
Collaborator

kalmarek commented Nov 8, 2018

is a test that n>0 (e.g. in https://github.com/JuliaOpt/SCS.jl/blob/master/src/c_wrapper.jl#L39) sufficient?

@blegat
Copy link
Member Author

blegat commented Nov 8, 2018

Yes, and also check that m is greater than zero.

@kalmarek kalmarek mentioned this issue Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/empty model kalmarek/SCS.jl
2 participants
@blegat @kalmarek