Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #12

Merged
merged 14 commits into from
Apr 13, 2022
Merged

Dev #12

merged 14 commits into from
Apr 13, 2022

Conversation

jumploop
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 13, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 7.80%.

Quality metrics Before After Change
Complexity 11.30 🙂 15.80 🙂 4.50 👎
Method Length 29.12 ⭐ 38.56 ⭐ 9.44 👎
Working memory 6.83 🙂 7.55 🙂 0.72 👎
Quality 69.17% 🙂 61.37% 🙂 -7.80% 👎
Other metrics Before After Change
Lines 356 530 174
Changed files Quality Before Quality After Quality Change
func/convert_fahrenheit_to_celsius.py 93.64% ⭐ 92.93% ⭐ -0.71% 👎
func/is_leap.py 88.69% ⭐ 90.98% ⭐ 2.29% 👍
func/rate_limit.py 56.57% 🙂 56.56% 🙂 -0.01% 👎
z42/_lua_debug.py % 95.34% ⭐ %
z42/hg_close_branch 91.28% ⭐ 56.05% 🙂 -35.23% 👎
z42/hg_update_branch 91.28% ⭐ 62.38% 🙂 -28.90% 👎
z42/print_ac_route % 71.37% 🙂 %
z42/print_route % 83.87% ⭐ %
z42/replace_line.py 61.09% 🙂 61.07% 🙂 -0.02% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
z42/hg_close_branch main 38 ⛔ 235 ⛔ 10 😞 28.94% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
z42/hg_update_branch main 27 😞 197 😞 11 😞 34.42% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
func/rate_limit.py rate_limited 27 😞 148 😞 11 😞 38.92% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
func/rate_limit.py rate_limited.decorate 22 😞 126 😞 11 😞 44.47% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
func/rate_limit.py rate_limited.decorate.rate_limited_function 17 🙂 117 🙂 11 😞 49.20% 😞 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot mentioned this pull request Apr 13, 2022
@jumploop jumploop merged commit b70a79e into master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant