relativenumber is turned off for buffers opened in a split via fzf

[naps62]

• Category
  • Question
  • Bug
  • Suggestion
• OS
  • Linux
  • macOS
  • Windows
  • Etc.
• Vim
  • Vim
  • Neovim

This seems to happen in neovim (v0.2.0), but not in vim

Reproducing

1. open a minimal vim setup (taken from the issue template):

nvim -Nu <(curl https://gist.githubusercontent.com/junegunn/6936bf79fedd3a079aeb1dd2f3c81ef5/raw)`

2. set up relative line numbers:

:set relativenumber

3. open a file via the :Files command in a horizontal or vertical split or tab (i.e. search for any file, and press Ctrl-X, Ctrl-V or Ctrl-T)

4. The newly open buffer will not have relative numbers enabled

Doing something such as autocmd BufEnter * set relativenumber does not seem to help
Also, opening the new file in the same buffer instead of in a split does not trigger the issue

This issue does not occur with set number. only relative numbers seem to be affected

[junegunn]

Does this seem related? junegunn/fzf#930

[naps62]

@junegunn It seems similar, and could be related, but it's not exactly the same thing. That issues seems to disable vim's relativenumber option globally as soon as you open an fzf panel.

My issue happens when I open a split via FZF. But if I later open a new split through some other method (nerdtree, or simply :e, that buffer will have relativenumber set up as expected.

Also, not sure if relevant, but that issue is marked as happening in both neovim and vim, where mine seems to not happen on my vim installation, and only in neovim

[junegunn]

The vim plugin of fzf and fzf.vim do not set or unset relativenumber (you can't find the term anywhere in the source code), so I'm pretty sure it's a Neovim issue. If you still have issues with the latest Neovim compiled with neovim/neovim#6796, you might want to contact the Neovim guys.

[naps62]

@junegunn I can confirm that building neovim from their master branch fixes the issue. Thanks!

Oh, and thank you for an awesome tool

[rcorre]

It seems fixed on neovim master, but the FZF split now has line numbers. Is that expected?

[junegunn]

Seems like now terminal windows follow the same default options as other windows. Do you think fzf should override and disable line numbers?

[junegunn]

Related: neovim/neovim#6832

[rcorre]

Do you think fzf should override and disable line numbers?

I would like that, and think it is reasonable. Line numbers don't contribute useful information within the FZF pane and just take up space.

Alternatively FZF could instruct users to use this solution from the issue you referenced:

au TermOpen * setlocal nonumber norelativenumber

That disables lines in all terminal buffers though, which may not be desirable.

[junegunn]

See junegunn/fzf@a2604c0

Let me know if you run into any issues.

[rcorre]

Works for me, thanks!