Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish shell support - installer / keybindings #33

Closed
junegunn opened this issue Mar 31, 2014 · 4 comments
Closed

fish shell support - installer / keybindings #33

junegunn opened this issue Mar 31, 2014 · 4 comments
Assignees

Comments

@junegunn
Copy link
Owner

Regardless of on whatever shell it may be, fzf is installable simply by placing fzf in a directory included in $PATH. However, the install script generates an optimal function wrapper for fzf and defines some useful key bindings. It would be nice if it supports fish as well.

@dimonomid
Copy link

I tried to implement fzf support for fish some days ago, but unfortunately I'm running into a fish issue that does not yet have a solution. Details are below:

My message on the fish mailing list: http://sourceforge.net/p/fish/mailman/message/32161318/
The issue on github: fish-shell/fish-shell#1362

Author of fish shell even haven't answered yet does it agree it's a fish bug, or not.

@junegunn
Copy link
Owner Author

@dimonomid Thanks! In fact, I've never used fish shell, so I hoped for some help in this. So, as far as I understand, the problem is that fish shell currently does not allow reading from STDIN in command substitution, right? If that's the limitation of fish shell, we're out of luck.

But fortunately, I think there's still something we can do. I don't know if you have noticed but I've recently implemented tmux-integration for CTRL-T keybinding, which splits the window and starts fzf there, and sends output back to the original pane as you can see in the following gif.

fzf-tmux

This scheme might allow us to implement the feature without using command substitution. Basic idea is to save the result of fzf into a temporary file, then use the content of the file with tmux send-keys command.

It will be only available in a tmux session, but still it's better than nothing. If you're interested in contributing on this, I'd be grateful.

@junegunn
Copy link
Owner Author

junegunn commented May 2, 2014

Implemented in 7d15071 (doesn't require tmux).

@junegunn junegunn closed this as completed May 2, 2014
@da99
Copy link

da99 commented Jan 28, 2016

In case other Fish users read this, here is an alternative:

fzf | read  MYRESULT; and vim $MYRESULT

That's good when the result is one line. For multiple selections, fzf -m, the best solution so far is the one @junegunn posted using a temp file.

junegunn pushed a commit that referenced this issue Jan 16, 2024
EastAsianWidth.txt, use the record with "F"(FULLWIDTH) field as same as "W"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants