Merge fish history before showing history widget

[ismay]

Checklist

• I have read through the manual page (man fzf)
• I have searched through the existing issues
• For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.52.1

OS

• Linux
• macOS
• Windows
• Etc.

Shell

• bash
• zsh
• fish

Problem / Steps to reproduce

In this function: https://github.com/junegunn/fzf/blob/master/shell/key-bindings.fish#L59-L86 we're currently only showing the changes from the current session. If we call history merge beforehand commands from other sessions will be available as well.

Docs on history merge:

Immediately incorporates history changes from other sessions. Ordinarily fish ignores history changes from sessions started after the current one. This command applies those changes immediately.

from: https://fishshell.com/docs/current/cmds/history.html

We could do it similar to this widely used plugin: PatrickF1/fzf.fish, which also incorporates a check for private mode.

[junegunn]

Sounds good. Are you interested in opening a pull request?

[ismay]

Yeah sounds good. I should have time for it this week.

[ismay]

Actually it's not a lot of work, so I just created the PR now.

[adamsb6]

Would you entertain a PR to make this configurable? This is leading to lots of confusion for me, I typically have dozens of sessions open and I expect that when I arrow up in one of them, or search, I get the most recent for that session unless I've explicitly merged history.

It's especially pernicious when the command is super long and one arg is just slightly different, I'll end up breezing past it.

[junegunn]

Looks like you can set $fish_private_mode. See https://github.com/junegunn/fzf/pull/3852/files

[adamsb6]

I thought so at first, but that variable will cause zero history to be written. I still want my history, I just don’t want it merged with every fzf invocation.

…

On Fri, Oct 25, 2024 at 5:35 PM Junegunn Choi ***@***.***> wrote: Looks like you can set $fish_private_mode. See https://github.com/junegunn/fzf/pull/3852/files — Reply to this email directly, view it on GitHub <#3851 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFBX4TZZX5FLI2HT5QI4PDZ5LPSVAVCNFSM6AAAAABJCNKXRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGA4DINBUGA> . You are receiving this because you commented.Message ID: ***@***.***>