Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget: latest version is v0.54.0 instead of 0.54.0 #3927

Closed
5 of 10 tasks
jathek opened this issue Jul 16, 2024 · 3 comments
Closed
5 of 10 tasks

Winget: latest version is v0.54.0 instead of 0.54.0 #3927

jathek opened this issue Jul 16, 2024 · 3 comments

Comments

@jathek
Copy link

jathek commented Jul 16, 2024

Checklist

  • I have read through the manual page (man fzf)
  • I have searched through the existing issues
  • For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.53.0 (c4a9ccd) [before --force upgrade]

OS

  • Linux
  • macOS
  • Windows
  • Etc.

Shell

  • bash
  • zsh
  • fish

Problem / Steps to reproduce

The most recent release was pushed to winget as v0.54.0, not 0.54.0. As a result, although searching for fzf lists the new version, the winget install process does not believe there is a new version to upgrade to. Specifying v0.54.0 to winget doesn't work. I was finally able to get it upgraded with the --force command, but wanted to file the issue in case there is something wrong with the winget release workflow.

image

@junegunn
Copy link
Owner

Thanks for the report. We did change the tagging strategy.

9e92b6f

And Winget release is done via a GitHub Actions workflow.

version: ${{ github.event.release.tag_name }}

I didn't know it would disturb upgrades, it looks like I should have changed the spec to drop v prefix. Is there anyway I can make it right?

@junegunn
Copy link
Owner

https://github.com/vedantmgoyal9/winget-releaser?tab=readme-ov-file#configuration-options-%EF%B8%8F

I can just remove version from the spec, but I'm not sure if it's okay to re-release 0.54.0.

@junegunn
Copy link
Owner

junegunn commented Jul 18, 2024

Fixed in microsoft/winget-pkgs#163342.

According to microsoft/winget-pkgs#163342 (comment), the upgrade issue is fixed on the preview version of the client. You might want to check it out.

HenrikBengtsson added a commit to HenrikBengtsson/CBI-software that referenced this issue Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants