Improve find command for cd widgets: exclude proc/dev
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore Travis failure. I momentarily gave up making it work. |
Heh.. :) - I was just wondering. |
|
Feel free to squash-merge the commits, or tell me to rebase the PR. |
|
Doh, one thing I noticed is that jg@mbp:~> find . | cut -b3- | head
.agignore
.ansible
.ansible/cp
.ansible/tmp
.ansible/tmp/ansible-1355468543.5-175586869495702
.ansible/tmp/ansible-1355468608.74-15792789855106
.ansible/tmp/ansible-1355468672.32-65045913254503
.ansible/tmp/ansible-1355468717.3-263255040481250
.ansible/tmp/ansible-1355468798.05-74592742241722We could append |
| @@ -369,14 +369,15 @@ function fzf_key_bindings | |||
| end | |||
|
|
|||
| function __fzf_list | |||
| command find * -path '*/\.*' -prune \ | |||
| command find -L ${1:-.} \( -path '*/\.*' -o -fstype 'dev' -o -fstype 'proc' \) -prune \ | |||
There was a problem hiding this comment.
Fish complains about this:
fish: Did you mean {$VARIABLE}? The '$' character begins a variable name. A bracket, which directly followed a '$', is not allowed as a part of a variable name, and variable names may not be zero characters long. To learn more about variable expansion in fish, type 'help expand-variable'.
Standard input: command find -L ${1:-.} \( -path '*/\.*' -o -fstype 'dev' -o -fstype 'proc' \) -prune \
^
Let's just change it to simple .
When using the widget in "/", it would descend into 'dev/'. Using '*' for the starting path would do so also with the new '-fstype' excludes. `cut -b3-` and `sed 1d` have been added to massage the different format of the list. This also uses `-L` with all calls to find, especially for the file finders. Ref: junegunn#122
blueyed
force-pushed
the
improve-find-cdwidget
branch
from
325032c
to
53d5d9d
Compare
|
Fish should be fixed now, and I've added |
junegunn
added a commit
that referenced
this pull request
Jan 25, 2015
Improve `find` command for ALT-C: exclude proc/dev
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the widget in "/", it would descend into 'dev/'.
Using '*' for the starting path would do so also with the new '-fstype'
excludes.
The drawback / change now is that the './' prefix is being added, which
I don't mind. This could be fixed by throwing in some
cut -b3-intothe pipe.