Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect $FZF_DEFAULT_OPTS_FILE in key bindings and completion #3742

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Respect $FZF_DEFAULT_OPTS_FILE in key bindings and completion #3742

merged 5 commits into from
Apr 19, 2024

Conversation

junegunn
Copy link
Owner

@junegunn junegunn commented Apr 18, 2024 •
edited

Fix #3740

  • Need more testing.
  • Fish

@junegunn junegunn self-assigned this Apr 18, 2024
@junegunn junegunn marked this pull request as ready for review April 18, 2024 14:16
junegunn
junegunn commented Apr 19, 2024
View reviewed changes
shell/key-bindings.bash Outdated Show resolved Hide resolved
yujinyuz
yujinyuz approved these changes Apr 19, 2024
View reviewed changes
Copy link

@yujinyuz yujinyuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Tested by doing

./bin/fzf --fish | source

CTRL-T works now

@junegunn junegunn merged commit f864f8b into master Apr 19, 2024
5 checks passed
@junegunn junegunn deleted the shell-opts-file branch April 19, 2024 13:40
@junegunn
Copy link
Owner Author

Thanks for the test. Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujinyuz yujinyuz yujinyuz approved these changes

Assignees

@junegunn junegunn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect $FZF_DEFAULT_OPTS_FILE in key bindings and completion
2 participants
@junegunn @yujinyuz