Use unicode9 character widths #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current web-specific code implementation is not complete, and assumes non-east-asian. This is still an improvement because at least it compiles. But someone who has access to and is familiar with east-asian systems can complete the functionality.
Restore ability to compile to JavaScript.
Wrap関数を利用した際に、末尾の文字が消えてしまう問題を修正。
Wrap関数を利用した際に、末尾の文字が消えてしまう問題を修正。 (gofmted)
Before this change truncating "asdf" to a length of 4 with tail "…" will result in "asd…". After this change, it will return "asdf".
don't truncate when input already fits
|
Hi, please send the pull request directly to the upstream (https://github.com/mattn/go-runewidth). The purpose of this fork is only to make fzf unaffected by the changes made in the upstream. (There are of course better ways to manage dependencies in Go project, but anyway that's how I did it.) Once it's merged, just let me know, I'll update the fork. |
|
This change has been merged upstream. Please update here. |
junegunn
added a commit
to junegunn/fzf
that referenced
this pull request
Feb 2, 2017
|
Done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update runewidth to use unicode9 character width tables. This is the default in vim and neovim now, so should be safe to use in any terminal.
The
Conditionis no longer calculated usingIsEastAsian()as terminals do not use locale to determine how wide to draw ambiguous with characters. Rather, they simply default to 1, and may offer an option to set to 2 (which is discouraged).Once this repo is updated, when fzf is rebuilt, it will then use unicode9 widths as well.
All tests still pass. The API is very close to the way it was, but not identical. Still, fzf compiles using this version without issue.
A good example is to use fzf ctrl-r when there are emoji in the history. This should fix all rendering issues.