folding reverts to pre-goyo stage

[rafaeln]

When I enter goyo mode, unfold or fold some stuff, and then leave goyo mode, the folding comes back to what it was before I entered goyo mode.

[junegunn]

This one is tricky. Actually Goyo command opens the current buffer in a separate window in a new tab. Your modifications to the folds are then only local to this new window. In order to apply the updated folds back to the original window, Goyo has to save the information using mkview command. However the command seems to have backward compatibility issue, in other words, it works differently on older versions on Vim. So I'm not sure if I want to implement this at the moment.

[rafaeln]

What if you implemented a version check at the beginning of the script to decide whether to activate this functionality?

On Monday, April 28, 2014, Junegunn Choi notifications@github.com wrote:

This one is tricky. Actually Goyo command opens the current buffer in a
separate window in a new tab. Your modifications to the folds are then only
local to this new window. In order to apply the updated folds back to the
original window, Goyo has to save the information using mkview command.
However the command seems to have backward compatibility issue, in other
words, it works differently on older versions on Vim. So I'm not sure if I
want to implement this at the moment.

Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-41556959
.

[junegunn]

I've confirmed that :mkview works as expected on Vim 7.0 as well, I was mistaken. So, I was able to implement fold preservation using mkview and source (not loadview). However, I'm running into a number of nasty problems: enew triggered on unnamed or "nofile" buffers, syntax highlighting occasionally lost, mkview not working with close, etc. Currently I can't spend more time on this issue, but I'll try to keep you updated with the progress. And feel free to send me a pull request if you know a better way of doing it.

[rafaeln]

I read the documentation of mkview and I concluded it did too many things. It would be nice to have a pair of functions that only saved/restored the folding. But since they don't exist, I also don't think it's worth anyone's time to try and implement this feature. I guess I'll just close this bug.

[junegunn]

I thought I was going to keep this issue open. But I guess you're right, obviously there's no clean way to accomplish it. Thanks.