-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Integration tests: Docker, tmux, Neovim #124
Open
blueyed
wants to merge
19
commits into
junegunn:master
Choose a base branch
from
blueyed:integration-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
changed the title
Integration tests: Docker, tmux, Neovim
[WIP] Integration tests: Docker, tmux, Neovim
Apr 2, 2017
This wraps the temporary script into a function to get the line number of `vader#assert` calls.
E.g. ( 1/13) [EXECUTE] (X) Vim(finish):E168: :finish used outside of a sourced file > /home/user/src/neomake/tests/utils.vader:11: finish " foo Also passes it through to `s:execute`.
This will use the actual file name for included lines. Fixes junegunn#88.
Wrapping the code in a function will cause them to not be available otherwise, or g:SyntaxAt() would have to be used.
While this means more overhead in general, it allows to access script-local variables in the tests. squash! FEAT: move s:prepare into vader#window#execute Use `vader#log` directly instead of `:Log`, since the latter might not be defined (yet).
This uses a Docker image (currently blueyed/vader.vim, based on vim-testbed), and runs the test in there. This improves the overall build time, since Vim does not have to be compiled, and tests against different Vim version. I have also added neovim to the build matrix. Vim 7.3 currently fails since Ruby is not installed therein.
This reverts commit 5b70f64.
blueyed
force-pushed
the
integration-tests
branch
from
April 21, 2017 11:22
8ecd5c7
to
0925424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #123 and #107.
It is based on Neomake's tests, and the tmux part inspired by vim-diminactive's tests.
This uses a Docker image (currently blueyed/vader.vim, based on vim-testbed), and runs the test in there.
This improves the overall build time, since Vim does not have to be compiled, and tests against different Vim version.
I have also added neovim to the build matrix.
Vim 7.3 currently fails since Ruby is not installed therein (will be fixed with Vimjas/vim-testbed#23 / Vimjas/vim-testbed#9).