Add names for parameterized tests. Fixes #24 and #44. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. In order that you can easily identify individual test, you may provide a name for the Parameters annotation. @parameters(name="my test") This name is allowed to contain placeholders, which are replaced at runtime. The placeholders are * {index} - the current parameter index * {0} - the first parameter * {1} - the second parameter * ... - the other parameters If you don't use the name parameter, then the current parameter index is used as name. Example: When you use @parameters(name="fib({0})={1}") with the Fibonacci example, then you get test names like "fib(3)=2". This feature is based on the work of Dimitar Dimitrov (pull request junit-team#145). Thank you.
| @Override | ||
| protected Annotation[] getRunnerAnnotations() { | ||
| return new Annotation[0]; | ||
| } | ||
| } | ||
|
|
||
| private static final List<Runner> NO_RUNNERS= Collections | ||
| .<Runner> emptyList(); |
There was a problem hiding this comment.
What column limit are you formatting with? Some of these lines seem to be wrapped pretty early
There was a problem hiding this comment.
I use the standard settings: org.eclipse.jdt.core.formatter.lineSplit=80.
| String finalPattern= namePattern.replaceAll("\\{index\\}", | ||
| Integer.toString(index)); | ||
| String name= MessageFormat.format(finalPattern, parameters); | ||
| return "[" + name + "]"; |
There was a problem hiding this comment.
Should the added brackets be mentioned in the javadoc?
|
Many thanks! |
|
Running the example from the Javadoc in Eclipse will show this 7-year-old bug: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order that you can easily identify individual test, you may provide a name for the Parameters annotation.
@parameters(name="my test")
This name is allowed to contain placeholders, which are replaced at runtime. The placeholders are
If you don't use the name parameter, then the current parameter index is used as name.
Example:
When you use @parameters(name="fib({0})={1}") with the Fibonacci example, then you get test names like "fib(3)=2".
This feature is based on the work of Dimitar Dimitrov (pull request#145). Thank you.