Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend generating Eclipse project files with Maven #1757

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Recommend generating Eclipse project files with Maven #1757

merged 1 commit into from
Feb 7, 2023

Conversation

kcooney
Copy link
Member

@kcooney kcooney commented Jan 22, 2023

No description provided.

@kcooney kcooney mentioned this pull request Jan 22, 2023
Closed
bhuvanaindukuri
bhuvanaindukuri approved these changes Jan 24, 2023
View reviewed changes
Copy link

@bhuvanaindukuri bhuvanaindukuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising to see these files committed to the repo in the first place.

@kcooney
Copy link
Member Author

kcooney commented Feb 2, 2023

Surprising to see these files committed to the repo in the first place.

@bhuvanaindukuri they date back from when JUnit was built using Ant. So it's actually not that surprising at all.

@kcooney kcooney requested a review from sbrannen February 2, 2023 20:37
@kcooney kcooney merged commit e50487c into junit-team:main Feb 7, 2023
@kcooney kcooney deleted the eclipse-maven branch February 7, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhuvanaindukuri bhuvanaindukuri bhuvanaindukuri approved these changes

@marcphilipp marcphilipp marcphilipp approved these changes

@sbrannen sbrannen Awaiting requested review from sbrannen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kcooney @marcphilipp @bhuvanaindukuri