JUnit vintage failing with "The forked VM terminated without properly saying goodbye" #801
Assignees
Comments
|
Would be great if this could be fixed for M5. This is currently preventing us from starting to use JUnit5 (using the vintage engine). Any thought on this? Thanks a lot! |
|
Hi @vmassol -- I am no Maven/Surefire expert. But I don't see a class from our JUnit Platform Surefire Provider in the stacktrace you posted. See section 4.2.2. Maven for configuration steps. Or this answered SO question: http://stackoverflow.com/questions/36970384/surefire-is-not-picking-up-junit-5-tests Hope that helps. |
|
@sormuras Thanks. Here's what I do more precisely: Step 1: Run "mvn clean install" on https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwiki-platform-oldcore with the following surefire configuration: Result: passing Step 2: Run "mvn clean install" again but with the following changes to the pom.xml: Result: Failing This is full error with Maven executed with -X: https://gist.github.com/vmassol/358a0bcbb2c55f9172aa067c346aa6c2 This is the surefire configuration from the execution with Maven with -X: As you can see at line 76 (https://gist.github.com/vmassol/5214aa7c8cfe9888497a174ce281daa6#file-gistfile1-txt-L76), it says Since the only change in step2 is the change to use junit5 and junit5 surefire provider and the vintage engine, it seems to me that there's a problem somewhere in it causing the test to fail. Unless you see some error in the way I configured junit5 to run our junit4 tests with Maven. But AFAIK I've followed the documentation and it works fine for building hundreds of other maven modules. It just fails on this one for some reason. Thanks for your help. |
|
My guess is that the |
|
@Tibor17 Do you have an idea how to debug this? |
|
@marcphilipp |
|
target/surefire-reports |
|
@vmassol Can you try using the latest snapshots of all JUnit 5 artifacts and see if the issue is still present? |
|
@marcphilipp will do ASAP and report back, thanks |
|
@marcphilipp could you tell me where to get the latest snapshots? I've found the CI job at https://junit.ci.cloudbees.com/job/JUnit5/ but I don't see where the generated artifacts are deployed to. In order to build with snapshots I need a maven repo (installing them by hand in my local repo is doable but is a pain). Thanks |
|
Thanks @nicolaiparlog , indeed I got confused initially but found the right artifacts by following the artifact ids from my pom :) Thx |
|
ok I've tried by adding the following to my pom.xml: And I get: Any idea? |
|
Maybe the snapshot version of the junit provider is not compatible with surefire 2.19.1 anymore? |
|
Yes, you have to switch to Surefire 2.20. |
|
ok so I get some more info: The dump file has tons of those: Any idea why this is passing fine with standard surefire but failing when using the junit5 surefire provider? Thanks! We're getting closer... |
|
So the new thread dump stuff seems to be something new in surefire 2.20 (We also got it when trying to upgrade our build to surefire 2.20: https://jira.xwiki.org/browse/XCOMMONS-1190). However the "The forked VM terminated without properly saying goodbye. VM crash or System.exit called?" is still there even when using the latest junit5 snapshot. |
|
You must be doing something in the fork like sending bytes to native
std/out via {{FileDescriptor.out}} or {{ProcessBuilder and inherited
channel}}.
…On Fri, May 5, 2017 at 1:08 PM, Vincent Massol ***@***.***> wrote:
So the new thread dump stuff seems to be something new in surefire 2.20
(We also got it when trying to upgrade our build to surefire 2.20:
https://jira.xwiki.org/browse/XCOMMONS-1190).
However the "The forked VM terminated without properly saying goodbye. VM
crash or System.exit called?" is still there even when using the latest
junit5 snapshot.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_yRyoYaiC4NeSH8Tw_rCNcpjgki9kxks5r2wMhgaJpZM4NEluL>
.
--
Cheers
Tibor
|
|
I guess it's the logger.
On Fri, May 5, 2017 at 1:15 PM, Tibor Digana <tibor.digana@googlemail.com>
wrote:
… You must be doing something in the fork like sending bytes to native
std/out via {{FileDescriptor.out}} or {{ProcessBuilder and inherited
channel}}.
On Fri, May 5, 2017 at 1:08 PM, Vincent Massol ***@***.***>
wrote:
> So the new thread dump stuff seems to be something new in surefire 2.20
> (We also got it when trying to upgrade our build to surefire 2.20:
> https://jira.xwiki.org/browse/XCOMMONS-1190).
>
> However the "The forked VM terminated without properly saying goodbye. VM
> crash or System.exit called?" is still there even when using the latest
> junit5 snapshot.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#801 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yRyoYaiC4NeSH8Tw_rCNcpjgki9kxks5r2wMhgaJpZM4NEluL>
> .
>
--
Cheers
Tibor
--
Cheers
Tibor
|
|
Thanks! I'll try to understand that more and review our tests to check this out. What logger are you referring to BTW? However on this comment https://issues.apache.org/jira/browse/SUREFIRE-1359?focusedCommentId=15969287&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15969287 you say that it shouldn't fail the build. So I'm still facing the issue of "The forked VM terminated without properly saying goodbye. VM crash or System.exit called?" which happens with junit5/vintage. |
|
So to make it clear:
Thanks |
|
The JUnit platform logs a few things (e.g. which engines are present) to stdin/stderr. You should be able to install a custom JUL LogManager (e.g. Log4J) and provide a config that suppresses all logging. Does that help? |
|
See `ForkedBooter` class in surefire.
We are overriding system out/err in the beginning of the `main()` method.
If you have any mechanism, like static code init, you can easily fetch
`System.out` beforehand and this means you cached PrintStream and later you
wrote bytes to the native stream and this is the issue.
…On Fri, May 5, 2017 at 4:24 PM, Marc Philipp ***@***.***> wrote:
The JUnit platform logs a few things (e.g. which engines are present) to
stdin/stderr. You should be able to install a custom JUL LogManager (e.g.
Log4J) and provide a config that suppresses all logging. Does that help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_yRwJJ35wBDlw6PfsC-9_qQfktGNG-ks5r2zEYgaJpZM4NEluL>
.
--
Cheers
Tibor
|
ok that must be it. We do have code like this using SLF4J: I don't know what SLF4J does but maybe it caches PrintStream. |
|
The problem in JUnit5 is this
<scope>runtime</scope>
The JUnit4 did not fail. It is src/main/java problem in main code of the
test project - similar to assertion error.
Remember that when you add a dependency to plugin it does not mean that
your provider is instantiated in plugin's ClassLoader. No, we load it in
isolated CL and the scope runtime does not cause the CL to inherit that one
class of logger means surefire-logger-api.
…On Thu, Apr 12, 2018 at 7:38 PM, Joakim Erdfelt ***@***.***> wrote:
To answer @Tibor17 <https://github.com/Tibor17> ... I've updated
https://github.com/jetty-project/junit-issue-801
There are 4 separate projects.
All 4 use the same version of maven-surefire-plugin
Project Name Description Behavior
junit5-forkcount-1 Junit 5 provider, Using <forkCount>1</forkCount> Crashes
with org.apache.maven.plugin.PluginExecutionException 💥
junit5-forkmode-always Junit 5 provider, Using <forkMode>always</forkMode> Crashes
with org.apache.maven.plugin.PluginExecutionException 💥
junit4-forkcount-1 Junit 4 default, Using <forkCount>1</forkCount> Terminates
with org.apache.maven.plugin.MojoFailureException ✔️
junit4-forkmode-always Junit 4 default, Using <forkMode>always</forkMode> Terminates
with org.apache.maven.plugin.MojoFailureException ✔️
So, there's 2 maven-surefire-plugin configurations that make the junit 5
surefire provider crash, but not the older junit 4 surefire provider ...
Scenario 1: forkCount with reuseForks
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.21.0</version>
<configuration>
<forkCount>1</forkCount>
<reuseForks>false</reuseForks>
</configuration>
</plugin>
Scenario 1: forkMode = always
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.21.0</version>
<configuration>
<forkMode>always</forkMode>
</configuration>
</plugin>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_yRxfVjL4LS6fo7AJX1dbqw7gDLNzpks5tn5ElgaJpZM4NEluL>
.
--
Cheers
Tibor
|
|
Tried to insert Index: junit5-forkmode-always/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- junit5-forkmode-always/pom.xml (revision fde3538877f4c48650b46d102a0abaeb35001992)
+++ junit5-forkmode-always/pom.xml (date 1523563308331)
@@ -30,23 +30,27 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-runner</artifactId>
<version>${junit.platform.version}</version>
+ <scope>test</scope>
</dependency>
<!-- junit jupiter -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.jupiter.version}</version>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit.jupiter.version}</version>
+ <scope>test</scope>
</dependency>
<!-- junit vintage -->
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${junit.vintage.version}</version>
+ <scope>test</scope>
</dependency>
</dependencies>
@@ -64,16 +68,6 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
<version>${junit.platform.version}</version>
- </dependency>
- <dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-engine</artifactId>
- <version>${junit.jupiter.version}</version>
- </dependency>
- <dependency>
- <groupId>org.junit.vintage</groupId>
- <artifactId>junit-vintage-engine</artifactId>
- <version>${junit.vintage.version}</version>
</dependency>
</dependencies>
</plugin>
Index: junit5-forkcount-1/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- junit5-forkcount-1/pom.xml (revision fde3538877f4c48650b46d102a0abaeb35001992)
+++ junit5-forkcount-1/pom.xml (date 1523563246445)
@@ -30,23 +30,27 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-runner</artifactId>
<version>${junit.platform.version}</version>
+ <scope>test</scope>
</dependency>
<!-- junit jupiter -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.jupiter.version}</version>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit.jupiter.version}</version>
+ <scope>test</scope>
</dependency>
<!-- junit vintage -->
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${junit.vintage.version}</version>
+ <scope>test</scope>
</dependency>
</dependencies>
@@ -65,16 +69,6 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
<version>${junit.platform.version}</version>
- </dependency>
- <dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-engine</artifactId>
- <version>${junit.jupiter.version}</version>
- </dependency>
- <dependency>
- <groupId>org.junit.vintage</groupId>
- <artifactId>junit-vintage-engine</artifactId>
- <version>${junit.vintage.version}</version>
</dependency>
</dependencies>
</plugin> |
|
You still do not understand.
…On Thu, Apr 12, 2018 at 10:08 PM, Christian Stein ***@***.***> wrote:
Tried to insert <scope>test</scope> in both JUnit 5 samples and removed
the dependencies from the sure plugin configuration ... and they still fail
with ClassNotFoundException: org.apache.maven.plugin.
surefire.log.api.ConsoleLogger
Index: junit5-forkmode-always/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8===================================================================--- junit5-forkmode-always/pom.xml (revision fde3538877f4c48650b46d102a0abaeb35001992)+++ junit5-forkmode-always/pom.xml (date 1523563308331)@@ -30,23 +30,27 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-runner</artifactId>
<version>${junit.platform.version}</version>+ <scope>test</scope>
</dependency>
<!-- junit jupiter -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.jupiter.version}</version>+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit.jupiter.version}</version>+ <scope>test</scope>
</dependency>
<!-- junit vintage -->
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${junit.vintage.version}</version>+ <scope>test</scope>
</dependency>
</dependencies>
@@ -64,16 +68,6 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
<version>${junit.platform.version}</version>- </dependency>- <dependency>- <groupId>org.junit.jupiter</groupId>- <artifactId>junit-jupiter-engine</artifactId>- <version>${junit.jupiter.version}</version>- </dependency>- <dependency>- <groupId>org.junit.vintage</groupId>- <artifactId>junit-vintage-engine</artifactId>- <version>${junit.vintage.version}</version>
</dependency>
</dependencies>
</plugin>
Index: junit5-forkcount-1/pom.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8===================================================================--- junit5-forkcount-1/pom.xml (revision fde3538877f4c48650b46d102a0abaeb35001992)+++ junit5-forkcount-1/pom.xml (date 1523563246445)@@ -30,23 +30,27 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-runner</artifactId>
<version>${junit.platform.version}</version>+ <scope>test</scope>
</dependency>
<!-- junit jupiter -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.jupiter.version}</version>+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit.jupiter.version}</version>+ <scope>test</scope>
</dependency>
<!-- junit vintage -->
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${junit.vintage.version}</version>+ <scope>test</scope>
</dependency>
</dependencies>
@@ -65,16 +69,6 @@
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
<version>${junit.platform.version}</version>- </dependency>- <dependency>- <groupId>org.junit.jupiter</groupId>- <artifactId>junit-jupiter-engine</artifactId>- <version>${junit.jupiter.version}</version>- </dependency>- <dependency>- <groupId>org.junit.vintage</groupId>- <artifactId>junit-vintage-engine</artifactId>- <version>${junit.vintage.version}</version>
</dependency>
</dependencies>
</plugin>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_yRwAeoU6N_YSrOS2f8Zltwl8AYkMjks5tn7Q5gaJpZM4NEluL>
.
--
Cheers
Tibor
|
|
Provider...
On Thu, Apr 12, 2018 at 10:12 PM, Tibor Digana <tibor.digana@googlemail.com>
wrote:
… You still do not understand.
On Thu, Apr 12, 2018 at 10:08 PM, Christian Stein <
***@***.***> wrote:
> Tried to insert <scope>test</scope> in both JUnit 5 samples and removed
> the dependencies from the sure plugin configuration ... and they still fail
> with ClassNotFoundException: org.apache.maven.plugin.surefi
> re.log.api.ConsoleLogger
>
> Index: junit5-forkmode-always/pom.xml
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8===================================================================--- junit5-forkmode-always/pom.xml (revision fde3538877f4c48650b46d102a0abaeb35001992)+++ junit5-forkmode-always/pom.xml (date 1523563308331)@@ -30,23 +30,27 @@
> <groupId>org.junit.platform</groupId>
> <artifactId>junit-platform-runner</artifactId>
> <version>${junit.platform.version}</version>+ <scope>test</scope>
> </dependency>
> <!-- junit jupiter -->
> <dependency>
> <groupId>org.junit.jupiter</groupId>
> <artifactId>junit-jupiter-engine</artifactId>
> <version>${junit.jupiter.version}</version>+ <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.junit.jupiter</groupId>
> <artifactId>junit-jupiter-params</artifactId>
> <version>${junit.jupiter.version}</version>+ <scope>test</scope>
> </dependency>
> <!-- junit vintage -->
> <dependency>
> <groupId>org.junit.vintage</groupId>
> <artifactId>junit-vintage-engine</artifactId>
> <version>${junit.vintage.version}</version>+ <scope>test</scope>
> </dependency>
> </dependencies>
> @@ -64,16 +68,6 @@
> <groupId>org.junit.platform</groupId>
> <artifactId>junit-platform-surefire-provider</artifactId>
> <version>${junit.platform.version}</version>- </dependency>- <dependency>- <groupId>org.junit.jupiter</groupId>- <artifactId>junit-jupiter-engine</artifactId>- <version>${junit.jupiter.version}</version>- </dependency>- <dependency>- <groupId>org.junit.vintage</groupId>- <artifactId>junit-vintage-engine</artifactId>- <version>${junit.vintage.version}</version>
> </dependency>
> </dependencies>
> </plugin>
> Index: junit5-forkcount-1/pom.xml
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8===================================================================--- junit5-forkcount-1/pom.xml (revision fde3538877f4c48650b46d102a0abaeb35001992)+++ junit5-forkcount-1/pom.xml (date 1523563246445)@@ -30,23 +30,27 @@
> <groupId>org.junit.platform</groupId>
> <artifactId>junit-platform-runner</artifactId>
> <version>${junit.platform.version}</version>+ <scope>test</scope>
> </dependency>
> <!-- junit jupiter -->
> <dependency>
> <groupId>org.junit.jupiter</groupId>
> <artifactId>junit-jupiter-engine</artifactId>
> <version>${junit.jupiter.version}</version>+ <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.junit.jupiter</groupId>
> <artifactId>junit-jupiter-params</artifactId>
> <version>${junit.jupiter.version}</version>+ <scope>test</scope>
> </dependency>
> <!-- junit vintage -->
> <dependency>
> <groupId>org.junit.vintage</groupId>
> <artifactId>junit-vintage-engine</artifactId>
> <version>${junit.vintage.version}</version>+ <scope>test</scope>
> </dependency>
> </dependencies>
> @@ -65,16 +69,6 @@
> <groupId>org.junit.platform</groupId>
> <artifactId>junit-platform-surefire-provider</artifactId>
> <version>${junit.platform.version}</version>- </dependency>- <dependency>- <groupId>org.junit.jupiter</groupId>- <artifactId>junit-jupiter-engine</artifactId>- <version>${junit.jupiter.version}</version>- </dependency>- <dependency>- <groupId>org.junit.vintage</groupId>- <artifactId>junit-vintage-engine</artifactId>- <version>${junit.vintage.version}</version>
> </dependency>
> </dependencies>
> </plugin>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#801 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yRwAeoU6N_YSrOS2f8Zltwl8AYkMjks5tn7Q5gaJpZM4NEluL>
> .
>
--
Cheers
Tibor
--
Cheers
Tibor
|
|
Excerpt from <project>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
[...]
<dependencies>
[...]
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-api</artifactId>
<version>2.19.1</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>common-java5</artifactId>
<version>2.19.1</version>
<scope>runtime</scope>
</dependency>
</dependencies>
</project>I guess, you refer to these scopes?
|
|
I will squash junit5 into a new branch as it seems to be more important
than Maven3 and we can go out with surefire version 2.22.0.
Let's see what the tests would say on CI.
…On Thu, Apr 12, 2018 at 10:43 PM, Christian Stein ***@***.***> wrote:
Excerpt from junit-platform-surefire-provider-1.1.1.pom
<http://central.maven.org/maven2/org/junit/platform/junit-platform-surefire-provider/1.1.1/junit-platform-surefire-provider-1.1.1.pom>
:
<project>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-surefire-provider</artifactId>
[...]
<dependencies>
[...]
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-api</artifactId>
<version>2.19.1</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>common-java5</artifactId>
<version>2.19.1</version>
<scope>runtime</scope>
</dependency>
</dependencies>
</project>
I guess, you refer to these scopes?
- Yes. *Now you do understand.*
--
Cheers
Tibor
|
|
Please add further questions, findings and solutions regarding the fork mode issue with the JUnit Platform Surefire Provider to #1367 Thanks. |
Looking forward to it! 👏 |
|
I have applied all changes from Surefire's branch "junit5".
I will resolve conflicts with Jenkins CI (compiler versions), then I will
try to fix bugs after tests and then I will try to apply all changes
appeared after
2f49071
and versions of new JUnit artifact versions.
…On Fri, Apr 13, 2018 at 2:28 PM, Sam Brannen ***@***.***> wrote:
I will squash junit5 into a new branch as it seems to be more important
than Maven3 and we can go out with surefire version 2.22.0.
Let's see what the tests would say on CI.
Looking forward to it! 👏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_yRyW5C6U8ykaeZG9sesxkC1YvkquQks5toJnvgaJpZM4NEluL>
.
--
Cheers
Tibor
|
|
I will create a pull request on GitHub because this needs Benedikt to
support Surefire.
4 tests he added failed and I have no idea why.
So I have updated versions from 5.0.0-M3 to 5.1.1 and from 1.0.0-M3 to
1.1.1 and I got a new problem because you have compiled one artifact with
JDK9:
[INFO] Restricted to JDK 1.8 yet
org.junit.platform:junit-platform-commons:jar:1.1.1:compile contains
META-INF/versions/9/org/junit/platform/commons/util/ModuleUtils.class
targeted to 53.0
Tests in error:
testJunit[16: JUnit
4.12.0-M2](org.apache.maven.surefire.its.JUnit4VersionsIT): Exit code was
non-zero: 1; command line and log = (..)
testJunit[17: JUnit
5.0.0-M2](org.apache.maven.surefire.its.JUnit4VersionsIT): Exit code was
non-zero: 1; command line and log = (..)
test(org.apache.maven.surefire.its.JUnit5IT): Exit code was non-zero: 1;
command line and log = (..)
test40(org.apache.maven.surefire.its.JUnitPlattformIT): Exit code was
non-zero: 1; command line and log = (..)
Tests run: 759, Failures: 0, Errors: 4, Skipped: 138
##########################################
[INFO] Running junitplattform.BasicTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.052 s <<< FAILURE! - in junitplattform.BasicTest
[ERROR] junitplattform.BasicTest.testSetUp() Time elapsed: 0.046 s <<<
FAILURE!
org.opentest4j.AssertionFailedError: setUp was not called
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:48)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:48)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:43)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:119)
at junitplattform.BasicTest.testSetUp(BasicTest.java:55)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] junitplattform.BasicTest#testSetUp setUp was not called
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
On Fri, Apr 13, 2018 at 8:57 PM, Tibor Digana <tibor.digana@googlemail.com>
wrote:
… I have applied all changes from Surefire's branch "junit5".
I will resolve conflicts with Jenkins CI (compiler versions), then I will
try to fix bugs after tests and then I will try to apply all changes
appeared after
2f49071
7c63fde927
and versions of new JUnit artifact versions.
On Fri, Apr 13, 2018 at 2:28 PM, Sam Brannen ***@***.***>
wrote:
> I will squash junit5 into a new branch as it seems to be more important
> than Maven3 and we can go out with surefire version 2.22.0.
> Let's see what the tests would say on CI.
>
> Looking forward to it! 👏
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#801 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yRyW5C6U8ykaeZG9sesxkC1YvkquQks5toJnvgaJpZM4NEluL>
> .
>
--
Cheers
Tibor
--
Cheers
Tibor
|
|
Here is pull request to JUnit 5 in Surefire
apache/maven-surefire#183
On Fri, Apr 13, 2018 at 11:47 PM, Tibor Digana <tibor.digana@googlemail.com>
wrote:
… I will create a pull request on GitHub because this needs Benedikt to
support Surefire.
4 tests he added failed and I have no idea why.
So I have updated versions from 5.0.0-M3 to 5.1.1 and from 1.0.0-M3 to
1.1.1 and I got a new problem because you have compiled one artifact with
JDK9:
[INFO] Restricted to JDK 1.8 yet org.junit.platform:junit-
platform-commons:jar:1.1.1:compile contains META-INF/versions/9/org/junit/
platform/commons/util/ModuleUtils.class targeted to 53.0
Tests in error:
testJunit[16: JUnit 4.12.0-M2](org.apache.maven.
surefire.its.JUnit4VersionsIT): Exit code was non-zero: 1; command line
and log = (..)
testJunit[17: JUnit 5.0.0-M2](org.apache.maven.
surefire.its.JUnit4VersionsIT): Exit code was non-zero: 1; command line
and log = (..)
test(org.apache.maven.surefire.its.JUnit5IT): Exit code was non-zero:
1; command line and log = (..)
test40(org.apache.maven.surefire.its.JUnitPlattformIT): Exit code was
non-zero: 1; command line and log = (..)
Tests run: 759, Failures: 0, Errors: 4, Skipped: 138
##########################################
[INFO] Running junitplattform.BasicTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.052 s <<< FAILURE! - in junitplattform.BasicTest
[ERROR] junitplattform.BasicTest.testSetUp() Time elapsed: 0.046 s <<<
FAILURE!
org.opentest4j.AssertionFailedError: setUp was not called
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:48)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:48)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:43)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:119)
at junitplattform.BasicTest.testSetUp(BasicTest.java:55)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] junitplattform.BasicTest#testSetUp setUp was not called
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------
------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------
------------
On Fri, Apr 13, 2018 at 8:57 PM, Tibor Digana ***@***.***
> wrote:
> I have applied all changes from Surefire's branch "junit5".
> I will resolve conflicts with Jenkins CI (compiler versions), then I will
> try to fix bugs after tests and then I will try to apply all changes
> appeared after
> 2f49071dfc9005f5
> 56543e34ca41027c63fde927
> and versions of new JUnit artifact versions.
>
> On Fri, Apr 13, 2018 at 2:28 PM, Sam Brannen ***@***.***>
> wrote:
>
>> I will squash junit5 into a new branch as it seems to be more important
>> than Maven3 and we can go out with surefire version 2.22.0.
>> Let's see what the tests would say on CI.
>>
>> Looking forward to it! 👏
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#801 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA_yRyW5C6U8ykaeZG9sesxkC1YvkquQks5toJnvgaJpZM4NEluL>
>> .
>>
>
>
>
> --
> Cheers
> Tibor
>
--
Cheers
Tibor
--
Cheers
Tibor
|
|
Great, @Tibor17! Thanks for taking the initiative! |
joakime
added a commit
to jetty/jetty.project
that referenced
this issue
Jun 14, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 13, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 16, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 24, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 25, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 29, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 29, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Aug 31, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Sep 4, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Sep 4, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.21.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Sep 4, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.22.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Sep 5, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.22.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy
pushed a commit
to jetty/jetty.project
that referenced
this issue
Sep 5, 2018
+ Changes needed for new Junit 5
+ Migrating from Vintage junit API to Jupiter junit API
+ Relies on SNAPSHOT jetty-test-helper
- this will be a formal release once this issue has been
resolved satisfactory
+ Have jenkins always pull latest SNAPSHOT for each build
+ Adding jetty.snapshots repository
+ Using surefire 2.22.0 per advice from junit
+ Ensuring <reuseForks>true</reuseForks> to work around issue junit-team/junit5#801
+ Disabling <forkMode>always</forkMode> in maven-surefire-plugin
due to bug junit-team/junit5#801
+ OSGi tests must remain at vintage due to PaxExam
+ Moving from vintage TestingDir to jupiter WorkDir
+ Fixing imports to use jupiter, not vintage
+ Migrating vintage ExpectedException to jupiter assertThrows
+ Migrating vintage TestName to jupiter TestInfo
+ Migrating @RunWith(Parameterized.class)
to @ParameterizedTest with Argument Sources
+ Migrating assertTrue(val.contains(needle))
to assertThat(val, containsString(needle))
+ Aligning junit versions per recommendations from @sormuras
+ Adjusting parameter order change for assertEquals()
+ Test LifeCycle Annotation Migration
junit 4 | junit 5 / jupiter
------------ | -----------
@before | @beforeeach
@after | @AfterEach
@BeforeClass | @BeforeAll
@afterclass | @afterall
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While building https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwiki-platform-oldcore with vintage 4.12.0-M4 I get the error:
"The forked VM terminated without properly saying goodbye. VM crash or System.exit called?"
This module builds fine with "standard" Maven surefire:
But it fails when using:
The console has:
To reproduce:
mvn clean install -rf xwiki-platform-core/xwiki-platform-oldcore/Thanks!
The text was updated successfully, but these errors were encountered: