Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1858 add ThreadPoolHierarchicalTestExecutorService as optional alternative to ForkJoinPoolHierarchicalTestExecutorService (resolve JUnit 5 + Selenium 4 + Parallelism-issues) #2805

Closed
wants to merge 3 commits into from

Conversation

christophs78
Copy link

@christophs78 christophs78 commented Dec 31, 2021

Overview

This draft-PR ist kind of a POC how we may able to solve #1858 and SeleniumHQ/selenium#9359.
I´d like to collect your feedback before investing more time into this PR.

IMO ForkJoinPoolHierarchicalTestExecutorService still should be default for parallel execution. ThreadPoolHierarchicalTestExecutorService may become kind of an configureable alternative for special usecases.

(Some more details regarding the root cause for this issue see #1858 (comment))

CC @titusfortner


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

currently only works for
junit.jupiter.execution.parallel.mode.default = same_thread
junit.jupiter.execution.parallel.mode.classes.default = concurrent
@christophs78 christophs78 changed the title #1858 resolve JUi #1858 resolve JUnit 5 + Selenium 4 + Parallelism-issues Dec 31, 2021
@christophs78 christophs78 changed the title #1858 resolve JUnit 5 + Selenium 4 + Parallelism-issues #1858 add ThreadPoolHierarchicalTestExecutorService as optional alternative to ForkJoinPoolHierarchicalTestExecutorService (resolve JUnit 5 + Selenium 4 + Parallelism-issues) Jan 1, 2022
@christophs78
Copy link
Author

superseded by #2806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant