Generate JRE enum and dependent tests and add JAVA_24 #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcphilipp
commented
Jun 11, 2024
marcphilipp
commented
- Generate code based on YaML file
- Simplify task dependencies
- Add JTE dependency
- Generate JRE enum
- Extract JavaVersionPredicates
- Generate JavaVersionPredicates
- Simplify tests
- Introduce project sub dir
- Generate DisabledOnJreIntegrationTests
- Generate EnabledOnJreIntegrationTests
- Move generated sources to conventional target dir
- Generate EnabledOnJreConditionTests
- Generate DisabledOnJreConditionTests
- Add license header to generated sources
- Move template model and data to separate project
- Move templates to subprojects
- Clean up dependencies
- Add JRE.JAVA_24
marcphilipp
commented
Jun 11, 2024
Comment on lines
+29
to
+30
| - version: 24 | ||
| since: '5.11' |
There was a problem hiding this comment.
💬 New JDK versions can now be added with two lines. 🎉
There was a problem hiding this comment.
I recognize a code wizard when I see one. Well done, Marc! 🧙
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.