Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TempDir cleanup is executed when validation fails #3911

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Aug 1, 2024

Overview

See #3901 (comment).


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@scordio scordio changed the title Ensure closure of TempDir factory when temp directory validation fails Ensure closure of TempDir factory if temp directory validation fails Aug 1, 2024
@scordio scordio marked this pull request as draft August 5, 2024 15:11
@scordio
Copy link
Contributor Author

scordio commented Aug 7, 2024

Change is documented in the User Guide and Release Notes

I didn't add any release note about this change but let me know if we should have one.

@scordio scordio marked this pull request as ready for review August 7, 2024 06:50
@marcphilipp marcphilipp changed the title Ensure closure of TempDir factory if temp directory validation fails Ensure TempDir cleanup is executed when validation fails Aug 7, 2024
@marcphilipp marcphilipp merged commit 31aadda into junit-team:main Aug 7, 2024
15 checks passed
@marcphilipp
Copy link
Member

@scordio Thanks! 👍

@scordio scordio deleted the issues/3900-close-factory branch August 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants