-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2 beta 2: incorrect path generation for this.view in controller #70
Comments
Based on the new folder structure ( http://edge.javascriptmvc.com/docs.html#!organizing ) it should get
How are you calling this.view? |
well i just call this.view("view_name") my controller plugin name is "more_than_one_word" it tries to get my_app/views/morethanoneword/view_name so it tries morethanoneword (as a solid word) instead of more_than_one_word |
hm.. I did not closed it consciously at least |
can you provide a breaking test case? |
I added this test to jquery/controller/view/test recently: test("complex paths nested inside a controller directory", function(){
}) Yours is a variation of that it sounds like |
I'm going to close this. Please provide a breaking case (and test code) and reopen it. |
Well, maybe your concept has changed, but what I mean was: Myproject.Controllers.FooBar (For and Bar without dot). And in 3.1 i've got "_" (underline symbol between "foo" and "bar" in the generated path to a view ("foo_bar") and now I've got just "foobar" To be more concrete: So lets my controller class full name be: Project.Controllers.FooBar The point is that in 3.1: and in 3.2 there is some sophisticated code for controller_name and final view path, and so we've got now: |
It says I can not reopen this issue |
To be concrete, can't you just say something like: In 3.1: A.B.FooBar looks in a/b/foo_bar but in 3.2 A.B.FooBar looks in a/b/foobar Is that is what is happening? |
essentially the _ is getting lost. |
Yes, exaclty. |
This would be the breaking test:
|
Ok it should be fixed now. Just needed to run the controller name through jQuery.String.underscore. |
3.2 beta 2:
in controller with more than one word name (for example my_more_than_one_word_controller)
this.view("view_name", params) tries to get view with path:
my_app/views/mymorethanoneword/view_name
and i suppose it should:
my_app/views/my_more_than_one_word/view_name
so underline character is missed.
The text was updated successfully, but these errors were encountered: