Element API Overhaul #88
Conversation
|
Very much looking forward to this next release! |
py_src/ipyelk/elements/extended.py
Outdated
| # TODO need ability to resize the min width based on label/child max width | ||
| for child in self.children: | ||
| child.layoutOptions = merge( | ||
| opt.OptionsWidget( | ||
| options=[ | ||
| opt.NodeSizeConstraints(), | ||
| opt.NodeSizeMinimum(width=self.width, height=20), | ||
| opt.NodeSizeMinimum(width=int(self.width), height=20), |
There was a problem hiding this comment.
wonder if it would be worth it to add height as an attribute above...
There was a problem hiding this comment.
Maybe width should be min_width and height added as an attribute called min_height?
There was a problem hiding this comment.
Added a min_height but i think width is still cleaner. The intention is that this is width shared by all of the compartments. We might be able to set the width directly but then there is less feedback if the user "guessed" the wrong width (marks get rendered on top of each other instead of the compartment borders looking odd). There might be better ways to solve this in the future either with a dedicated "node:compartment" type (which has issues to being out of sync with how elkjs positioned the marks) or with multiple passes of layout calls to elkjs.
py_src/ipyelk/elements/symbol.py
Outdated
|
|
||
| @classmethod | ||
| def make_defs(cls, symbols: List["Symbol"]) -> Dict[str, "Symbol"]: | ||
| """Take a list of symbols and return the def dictionary |
There was a problem hiding this comment.
"""Take a list of symbols and return a dictionary with the symbol's identifier as the key ?
There was a problem hiding this comment.
Reworked into a separate SymbolSpec class
…dpointsymbol offset field names
Work In Progress
Goal is to try and streamline some of the api and schema for building diagrams.