🦶🎵 Implement footnotes in myst-to-tex #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwkoch
commented
Feb 23, 2023
packages/myst-to-jats/src/index.ts
Outdated
| @@ -393,6 +408,10 @@ const plugin: Plugin<[Options?], Root, VFile> = function (opts) { | |||
| const tree = copyNode(node) as any; | |||
| basicTransformations(tree, file); | |||
| const state = new JatsSerializer(file, opts ?? { handlers }); | |||
| const footnotes = selectAll('footnoteDefinition', tree) as FootnoteDefinition[]; | |||
There was a problem hiding this comment.
We handle footnoteDefinition nodes left in the tree here. This is nice and what we should move to everywhere...
There was a problem hiding this comment.
Nice, looking forward to that.
fwkoch
commented
Feb 23, 2023
| @@ -247,20 +248,30 @@ const handlers: Record<string, Handler> = { | |||
| include(node, state) { | |||
| state.renderChildren(node, true); | |||
| }, | |||
| footnoteReference(node, state) { | |||
| if (!node.identifier) return; | |||
| const footnote = state.references.footnotes?.[node.identifier]; | |||
There was a problem hiding this comment.
Here, we assume footnoteDefinition nodes have been pulled off the tree and are passed in separately. This is how myst-cli currently operates but is not super nice. We should move towards just leaving the footnote nodes in the tree rather than passing around a separate references object.
|
Looks good! Looking forward to implementing this properly in JATS, but will take another pass on the XML side. 🔜 |
rowanc1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.