👩💻 Improve HTML processing #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
commented
Oct 16, 2023
Comment on lines
+177
to
+183
| { | ||
| type: 'html', | ||
| value: '<hr>', | ||
| }, | ||
| { | ||
| type: 'html', | ||
| value: '<br>', |
There was a problem hiding this comment.
Self-closing HTML values are now correctly added.
rowanc1
commented
Oct 16, 2023
Comment on lines
+101
to
+106
| selectAll('paragraph > htmlParsed', tree).forEach((parsed) => { | ||
| const node = parsed as GenericParent; | ||
| if (node?.children?.length === 1 && node.children[0].type === 'paragraph') { | ||
| node.children = node.children[0].children as GenericNode[]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
HTML is by default added into a paragraph, if it is already contained in one -- this strips it.
24 tasks
fwkoch
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Nice - Any implications of pulling in the reconstructHtmlPlugin to the default behaviour? Probably not - it will just make the htmlPlugin better 🚀. Other than that, this PR adds: ✅ more custom handling of html, ✅ better self closing tags, and ✅ small paragraph nesting tweak. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a lot of the functionality around HTML processing to get it into the AST before any other transformations. We can now have things like
<figure><img src=""><figcaption>The caption</figcaption></figure>which will be processed into the correct container. This can also work with HTML links directly to that caption, which will be processed as normal.The IDs are required to be on the
figure, not theimage, but that seems reasonable.cc @dellaert who is motivated by having HTML that works in google collab, but also works with MyST for LaTeX export.
@fwkoch there are probably a number of other changes incoming for the HTML processing along these lines, but I think we can get them in iteratively.
Fixes: