Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release review #861

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Release review #861

merged 2 commits into from
Feb 6, 2024

Conversation

ljubon
Copy link
Collaborator

@ljubon ljubon commented Nov 30, 2023

Description

create a release workflow based on RELEASING.md
used bumpconfig to update versions

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. kind:enhancement A new Sparkmagic feature labels Nov 30, 2023
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljubon This is awesome. Are you able to run this on your fork to show what the output would be for a new release?

.github/workflows/release.yml Outdated Show resolved Hide resolved
@ljubon ljubon closed this Jan 10, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
refactor workflow, add workflow_dispatch
@ljubon ljubon reopened this Jan 10, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@ljubon
Copy link
Collaborator Author

ljubon commented Jan 18, 2024

Hi @devstein sorry for the messy history of this PR during rebase i accident matched this branch to master so PR automatically got closed
Let me know what do you thin of my proposal and if it works for your 🤞

Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Before I merge this, can you update the changelog (give yourself a shoutout : )) and the releasing instructions?

@devstein
Copy link
Collaborator

@ljubon Would you be interested in becoming a maintainer of sparkmagic?

@ljubon
Copy link
Collaborator Author

ljubon commented Jan 24, 2024

This is great!

Before I merge this, can you update the changelog (give yourself a shoutout : )) and the releasing instructions?

Got it, bot RELEASE.md and CHANGELOG.md are updated 👍

@ljubon
Copy link
Collaborator Author

ljubon commented Jan 24, 2024

@ljubon Would you be interested in becoming a maintainer of sparkmagic?

I would be honored to become a maintainer and help the community grow 🙏

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 6, 2024
@devstein
Copy link
Collaborator

devstein commented Feb 6, 2024

I would be honored to become a maintainer and help the community grow 🙏

Amazing! sparkmagic is widely use and we need the additional support

@devstein devstein merged commit 91748b3 into jupyter-incubator:master Feb 6, 2024
7 checks passed
@devstein devstein deleted the release-review branch February 6, 2024 20:38
@devstein
Copy link
Collaborator

devstein commented Feb 6, 2024

@ljubon I granted you write access 🚀 Let me know if you run into issues or have questions.

One of the low-effort, but higher priority tasks on the backlog is #811

In general, dependencies are relatively safe to bump. The dependencies that require significant scrutiny and testing is anything related to Jupyer (ipykernel, ipython, ipywidgets, jupyter-server, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:enhancement A new Sparkmagic feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants