Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not warned when deleting a job or job definition in Details view #107

Closed
JasonWeill opened this issue Oct 7, 2022 · 2 comments · Fixed by #152
Closed

User is not warned when deleting a job or job definition in Details view #107

JasonWeill opened this issue Oct 7, 2022 · 2 comments · Fixed by #152
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JasonWeill
Copy link
Collaborator

Description

When the user clicks "Delete Job" or "Delete Job Definition" from the details view, the job or job definition is deleted immediately, with no confirmation step. This is irreversible.

Expected behavior

The user should see a confirmation dialog (e.g., a modal) when they click a delete button so that they can confirm their decision to delete.

@JasonWeill JasonWeill added the bug Something isn't working label Oct 7, 2022
@ellisonbg
Copy link
Contributor

Another option is to have a single button that is two-stage delete. The first click on the "X" would turn that button into a more prominent (and red) delete button, which when clicked would actually delete the job. iOS does this in places and it is a bit more lightweight than a full dialog, which would get cumbersome for in situations where you are deleting jobs often, but not using (the yet to be built) multi-selection batch actions.

@andrii-i andrii-i assigned andrii-i and unassigned andrii-i Oct 12, 2022
@andrii-i andrii-i changed the title User is not warned when deleting a job or job definition User is not warned when deleting a job or job definition in Details view Oct 12, 2022
@andrii-i
Copy link
Collaborator

Created #142 to track Deletion confirmation in List View in a way described by @ellisonbg above. Renamed this issue to clarify that it tracks Deletion confirmation in Details View using modal confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants