Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More coverage #1067

Merged
merged 16 commits into from
Nov 12, 2022
Merged

More coverage #1067

merged 16 commits into from
Nov 12, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 12, 2022

  • Add coverage report config to ignore common patterns
  • Actually install pandoc on Ubuntu to improve nbconvert coverage
  • Add more utils coverage
  • Add shutdown_server coverage and include integration tests in overall coverage

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.14%. Comparing base (ca3c5b2) to head (dd46f62).
Report is 300 commits behind head on main.

Files with missing lines Patch % Lines
jupyter_server/serverapp.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
+ Coverage   73.89%   75.14%   +1.25%     
==========================================
  Files          64       63       -1     
  Lines        8267     8225      -42     
  Branches     1640     1635       -5     
==========================================
+ Hits         6109     6181      +72     
+ Misses       1745     1624     -121     
- Partials      413      420       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073 blink1073 enabled auto-merge (squash) November 12, 2022 17:15
@blink1073 blink1073 merged commit 81535d4 into jupyter-server:main Nov 12, 2022
@blink1073 blink1073 deleted the more-coverage branch November 12, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants