feat: add option to replace traceback on errors #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing a traceback can be a security risk in a context such as Voila. (for instance showing paths, usernames or values in the exception message) Similar to what we do at notebook execution time at: voila-dashboards/voila#758 here we also disable the transfer of tracebacks at runtime.
maartenbreddels
force-pushed
the
feat_replace_traceback
branch
from
1cd88ff
to
bcac032
Compare
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
Nov 2, 2020
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
Nov 2, 2020
maartenbreddels
added a commit
to maartenbreddels/voila
that referenced
this pull request
Nov 2, 2020
kevin-bates
approved these changes
Nov 3, 2020
Zsailer
approved these changes
Nov 4, 2020
|
@maartenbreddels, would you be able to write a test for this? If not, we should open an issue to remind ourselves to write a test at a later time. |
|
If you give me some pointers, I could take a look, maybe you know of a few test that would look similar. |
|
None of the current kernel tests send messages - they only test lifecycle management operations. It would be good to add such a test or two that exercises the channels handler and this change. I've gone ahead and created #330. |
|
Ok, great, then I prefer we merge this as is. |
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…ce_traceback feat: add option to replace traceback on errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing a traceback can be a security risk in a context such as Voila.
(for instance showing paths, usernames or values in the exception message)
Similar to what we do at notebook execution time at:
voila-dashboards/voila#758
here we also disable the transfer of tracebacks at runtime.
cc @SylvainCorlay @mariobuikhuizen