Check for ID before creating a new record #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
changed the title
Zsailer
commented
Apr 13, 2024
dlqqq
requested changes
Apr 15, 2024
Zsailer
commented
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a race condition appear when this extension is enabled in a server that has another extension using the file ID service in parallel.
My other extension is also watching updates to the file and trigger an
.get_id(...)call on a file when changes are made. If a file is, e.g. copied, the new file will have my extension and the file ID extension competing to set the new ID.To avoid errors thrown by the "Unique" constraint in the ArbitraryFileManager, I would like to propose that we check for an existing file ID in the
_createmethod before assigning a new UUID.