Add WidgetMarker #728
Draft
Add WidgetMarker #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
martinRenou
commented
Oct 17, 2020
Comment on lines
+392
to
+439
| class WidgetMarker(Marker): | ||
| _view_name = Unicode('LeafletWidgetMarkerView').tag(sync=True) |
|
Cool! Would like to see some tiny explanation about which point of the rendered widget the specified location will refer to, like lower-left (or rather South-West?), I'd assume. |
|
@deeplook I am actually not sure. If you look at the screenshot closely you'll see a small white square at the top-left of the button, I suspect this is the center of the marker but I am really not sure. |
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
widgetmarker
branch
from
993685b
to
a1d7687
Compare
|
I now position the widget at the center of the marker using CSS This is what happens if we have a WidgetMarker at the same position as a Marker: |
|
I might add a |
Signed-off-by: martinRenou <martin.renou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #717
This requires updating LeafletJS, we need to be extra careful that everything still works as expected after this.