Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the new Comm Python package #3533

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Using the new Comm Python package #3533

merged 6 commits into from
Mar 21, 2023

Commits on Mar 21, 2023

  1. Move comm package

    @martinRenou
    martinRenou committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    48a3d54 View commit details
    Browse the repository at this point in the history

  2. Fix wrongly written test 

    This test was supposed to fail, as setting the bottom_left value will
trigger a ipywidgets.Layout.send_state on `child.layout.grid_area = position`
(ipywidgets.widgets.widget_template.py L419) and on
`self.layout.grid_template_areas = grid_template_areas_css`
(ipywidgets.widgets.widget_template.py L448)
    @martinRenou
    martinRenou committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e78d151 View commit details
    Browse the repository at this point in the history

  3. Fix Python 3.7 test

    @martinRenou
    martinRenou committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    4e5dd22 View commit details
    Browse the repository at this point in the history

  4. Code suggestions 

    Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
    @martinRenou @maartenbreddels
    martinRenou and maartenbreddels committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    2a31b38 View commit details
    Browse the repository at this point in the history

  5. Add comment

    @martinRenou
    martinRenou committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    74ee640 View commit details
    Browse the repository at this point in the history

  6. Any

    @martinRenou
    martinRenou committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ad8ec43 View commit details
    Browse the repository at this point in the history