Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab widget with JupyterLab 4 #3787

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix tab widget with JupyterLab 4 #3787

merged 1 commit into from
Jun 20, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jun 15, 2023 •
edited
Loading

Fix #3785

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch martinRenou/ipywidgets/fix_tab_widget

@ndmlny-qs ndmlny-qs mentioned this pull request Jun 15, 2023
Closed
@JuanCab JuanCab mentioned this pull request Jun 15, 2023
Closed
@martinRenou
Copy link
Member Author

Quoting @ndmlny-qs, confirming that the issue is fixed by this PR

After running @martinRenou's PR #3787 the problem is resolved. In packages/controls/css/lumino.css there is a class named jupyter-widget-tab that handles the correct styling to resolve the issue.

@gutow
Copy link

gutow commented Jun 19, 2023

I am awaiting this fix to go in before my projects can support Jupyterlab > 4.0.

ibdafna
ibdafna approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@ibdafna ibdafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ibdafna ibdafna merged commit 52edd7c into jupyter-widgets:main Jun 20, 2023
@martinRenou martinRenou deleted the fix_tab_widget branch June 20, 2023 07:31
@martinRenou martinRenou mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibdafna ibdafna ibdafna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tabs not rendering properly in Jupyterlab 4.0.1
3 participants
@martinRenou @gutow @ibdafna