Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - /home/jovyan/work is confusing (documentation) #1969

Closed
4kbyte opened this issue Aug 17, 2023 · 2 comments · Fixed by #1971
Closed

[ENH] - /home/jovyan/work is confusing (documentation) #1969

4kbyte opened this issue Aug 17, 2023 · 2 comments · Fixed by #1971
Labels
type:Enhancement A proposed enhancement to the docker images

Comments

@4kbyte
Copy link

4kbyte commented Aug 17, 2023

What docker image(s) is this feature applicable to?

scipy-notebook

What change(s) are you proposing?

User Guide documentation suggests mounting a local directory ($PWD, etc.) to /home/jovyan/work to persist notebooks. An excellent suggestion, let's keep our data around.

But at no point in Quick Start, Selecting an Image, Running a Container, or Common Features does the documentation instruct you that by default, the notebook will save to /home/jovyan.

How does this affect the user?

The user will discover that their data didn't persist only upon running a new container.

Further, there's no immediately available troubleshooting topic or search query that will illuminate that you didn't click "work" in the left sidebar of jupyter-server. The natural inclination is to click the large, friendly Python logo to get a Python notebook, since after all, that's why your here.

But that notebook ends up in /home/jovyan.

Anything else?

I was running:

docker run --rm --name=jupyter \
  -p 8888:8888 -v $(pwd):/home/jovyan/work \
  -e RESTARTABLE=yes \
  jupyter/scipy-notebook:python-3.11.4 "$@"

I'm using jupyter for instructional purposes. My resolution is to mount $PWD to /home/jovyan (without the work folder) and accept that I end up with extra files on the host from jovyan's $HOME (which I presume could be an issue when selecting another image at a later date). Not a problem, since I'm primarily concerned with making sure I don't lose any .ipynb files.

@4kbyte 4kbyte added the type:Enhancement A proposed enhancement to the docker images label Aug 17, 2023
@4kbyte
Copy link
Author

4kbyte commented Aug 17, 2023

That "$@", by the way, is because I put the command in a file called start.sh, so that I could pass arguments to jupyter-server with sh start.sh ARGUMENT....

@4kbyte
Copy link
Author

4kbyte commented Aug 18, 2023

docker run --rm --name=jupyter \
  -p 8888:8888 -v "${PWD}":/home/jovyan/work \
  jupyter/scipy-notebook:python-3.11.4 \
    start-notebook.sh --ServerApp.root_dir=/home/jovyan/work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant