Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container images for the GPU version of TensorFlow and PyTorch Notebook #2095

Closed
y-vectorfield opened this issue Feb 19, 2024 · 7 comments · Fixed by #2100
Closed

Add container images for the GPU version of TensorFlow and PyTorch Notebook #2095

y-vectorfield opened this issue Feb 19, 2024 · 7 comments · Fixed by #2100
Labels
type:Enhancement A proposed enhancement to the docker images

Comments

@y-vectorfield
Copy link

y-vectorfield commented Feb 19, 2024

What docker image(s) is this feature applicable to?

pytorch-notebook, tensorflow-notebook

What change(s) are you proposing?

We can not implement the GPU version of TensorFlow and PyTorch on the containers using these images.
Therefore, I'd like to propose the images for the GPU version of TensorFlow and PyTorch Notebook images.

How does this affect the user?

We can implement the GPU version of TensorFlow and PyTorch on Jupyter Notebook using these images.

Anything else?

No response

@y-vectorfield y-vectorfield added the type:Enhancement A proposed enhancement to the docker images label Feb 19, 2024
@benz0li
Copy link
Contributor

benz0li commented Feb 19, 2024

Cross references:

@mathbunnyru
Copy link
Member

New CUDA enabled pytorch-notebook images are pushed and ready to use 🎉
https://quay.io/repository/jupyter/pytorch-notebook?tab=tags

@y-vectorfield
Copy link
Author

y-vectorfield commented Feb 24, 2024

@mathbunnyru , @johanna-reiml-hpi ,
Excellent!! Thank you very much.
Now, there is no TF version or Jax version.
@benz0li , @mathbunnyru ,
Can I contribute these versions?

@mathbunnyru
Copy link
Member

Excellent!! Thank you very much.

Most of the work was done by @johanna-reiml-hpi in #2091 🙂

Can I contribute these versions?

Yes. Please, create 2 separate PRs.

We already have a regular tensorflow image, and your PR should look very similar to the PR mentioned above (except it won't have common parts making variant feature work).
This might not work though - tensorflow is difficult to install, especially with GPU involved.
It would be nice to have cuda11 and cuda12 versions (so it will be the same as pytorch-notebook).

For jax, we don't have an image, and I haven't used this package - so if there are separate CPU and GPU packages, you should add a regular image, and then GPU variants for cuda11 and cuda12 as well.

Note: we have a policy on adding new images and packages, so I can't promise you your PRs will be merged. But it's definitely worth trying - at least we will know the current state of installing these packages on top of our images. If we won't merge these images, we can always merge new recipes.

@mathbunnyru
Copy link
Member

@y-vectorfield how is it going? Do you need any help?

@ChristofKaufmann
Copy link
Contributor

@mathbunnyru Would you also be interested for the CPU-only image to use tensorflow-cpu (207.2 MB) instead of tensorflow (475.3 MB)? According to the TensorFlow installation instructions tensorflow-cpu is an official build.

@mathbunnyru
Copy link
Member

@ChristofKaufmann I think it makes sense, especially if we will have separate cuda-enabled image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants