Do not bloat spark image with ENV variables #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Jan 16, 2024
| class HadoopVersionTagger(TaggerInterface): | ||
| @staticmethod | ||
| def tag_value(container: Container) -> str: | ||
| return "hadoop-" + _get_env_variable(container, "HADOOP_VERSION") |
There was a problem hiding this comment.
This is pretty useless, because it just says "3". And it custom builds people obviously know their Hadoop version, so they are not interested in tagging.
I also think that getting versions from env is not the best solution, programs should be able to tell their versions themselves.
mathbunnyru
commented
Jan 16, 2024
Comment on lines
-38
to
-41
| ENV SPARK_VERSION="${spark_version}" \ | ||
| HADOOP_VERSION="${hadoop_version}" \ | ||
| SCALA_VERSION="${scala_version}" \ | ||
| SPARK_DOWNLOAD_URL="${spark_download_url}" |
There was a problem hiding this comment.
These env variable names are not something common, it's something we made up, so I don't think we should set them in the images.
max-muoto
pushed a commit
to max-muoto/docker-stacks
that referenced
this pull request
Mar 10, 2024
* Do not bloat spark image with ENV variables * Remove HadoopVersionTagger
max-muoto
pushed a commit
to max-muoto/docker-stacks
that referenced
this pull request
Mar 10, 2024
* Do not bloat spark image with ENV variables * Remove HadoopVersionTagger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)