add requirements to setup.py

[Zsailer]

Installing with pip doesn't grab the minimum dependencies found in the requirements.txt (i.e. nbclean is required to create the demo book, but it's not included in the setup.py dependencies).

Would y'all like a PR to add these to the install_requires arg in the setup.py?

[choldgraf]

for sure, that's a good idea! I think this could be handled by doing something like:

with open('requirements.txt', 'r') as ff:
  lines = ff.readlines()
  install_packages = [ii.strip() for ii in lines]

...

   install_requires = install_packages

PR is welcome :-)

[Zsailer]

Great! Opening a PR now.

I usually hesitate to read dependencies from the requirements.txt file into the setup.py because of this article.

But, I suppose this distinction is unlikely to matter in jupyter-book, and it would be easier not to maintain two lists that might get out of sync.

[choldgraf]

yeah, I hear what you mean - gosh python packaging is so confusing to me haha. Let's keep an eye open for whether this ends up messing something up :-)

thanks for the idea and quick turnaround @Zsailer!

[Zsailer]

gosh python packaging is so confusing to me haha.

You're not alone! 😆

As a side note, Jupyter-book is awesome. It's my python replacement for bookdown. Great work here!