nbdime 4.x: TypeError: diff() got an unexpected keyword argument 'predicates'

[amotl]

Hi there,

first things first: Thanks a stack for conceiving and maintaining this excellent package.

We would like to report an error we just discovered on CI runs of another package which was pulling in nbclient<0.10, amongst others. It apparently got upgraded to nbdime 4.x, and failed:

TypeError: diff() got an unexpected keyword argument 'predicates'

-- https://github.com/pyveci/pueblo/actions/runs/6959942774/job/18938341659?pr=22#step:5:147

To work around the problem, we downgraded to nbdime<4 in the meanwhile

• Fix dependencies for test extra by downgrading to nbdime<4 pyveci/pueblo#23

With kind regards,
Andreas.

[ibressler]

Thanks for reporting and posting a solution! I did not find it yet by googling it :/
I run into it last week as well when tests using pytest_notebook failed (in a closed project) with that error message and no clues where this comes from (suspected our code, of course, but it did not lead anywhere obviously).
Best regards
Ingo

[krassowski]

This appears to be more of an issue of pytest-notebook not supporting nbdime 4.0 which is tracked in chrisjsewell/pytest-notebook#59.

On nbdime side this comes from a refactor in #639 (which yielded impressive performance gains), but I think there is no fault on nbdime side as it was a major release (of course other than not deprecating this argument earlier).

[amotl]

Dear Michał,

it was also happening in a pytest-notebook environment on our side, but I was not sure where to submit this issue.

I think there is no fault on nbdime side as it was a major release.

I totally agree. Thanks already to @renonat for reporting chrisjsewell/pytest-notebook#59 ¹.

Keep up the spirit, and with kind regards,
Andreas.

Footnotes

1. I think it will be safe to close this issue. Please re-open if you think it is more appropriate to let people find this easier until it will be resolved by pytest-notebook. ↩