Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git filter integration #335

Merged
merged 4 commits into from
Mar 14, 2018
Merged

Add git filter integration #335

merged 4 commits into from
Mar 14, 2018

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Dec 4, 2017

  • Adds capability for applying git filters according to git config.
  • Applies filter on remote as it should for calls to nbdiff with git refs.
  • As diff drivers/tools cannot correctly apply filters, it will always apply any filter on remote if the flag --use-filter is given, otherwise it will not consider filters.

@vidartf
Copy link
Collaborator Author

vidartf commented Dec 4, 2017

This could still benefit from tests on nbdiff with gitrefs, and on the git difftool.

@vidartf vidartf merged commit ac7358f into jupyter:master Mar 14, 2018
@vidartf vidartf deleted the git-filter branch March 14, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant