Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readthedocs automatic build #1587

Merged
merged 4 commits into from
May 18, 2022
Merged

Fix readthedocs automatic build #1587

merged 4 commits into from
May 18, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented May 18, 2022

According to the documentation, the readthedocs.yaml file should be renamed .readthedocs.yaml.
The readthedocs-requirements.txt should not be necessary anymore as the yaml file can run pip install .[docs] now.

jhamrick
jhamrick approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thanks!

@jhamrick jhamrick added this to the 0.8.0 milestone May 18, 2022
@jhamrick jhamrick merged commit 0152342 into jupyter:main May 18, 2022
@brichet brichet deleted the fix/readthedocs_auto branch May 19, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamrick jhamrick jhamrick approved these changes

Assignees
No one assigned
Labels
documentation maintenance
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brichet @jhamrick