Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jupyter css variable in labextension to manage colors with theme #1603

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Jun 16, 2022

Change the hard coded CSS color by Jupyterlab CSS variables in labextension to allow changing theme (light and dark).
Only the formgrader extension remains in light style as it depends on bootstrap.

@jtpio jtpio added this to the 0.8.0 milestone Jun 16, 2022
@jhamrick
Copy link
Member

Overall looks good, though I think the "lock" icon is the wrong color, as it is not visible in JupyterLab in either the white or dark theme (well you can almost see it in the dark theme).

image

image

Compare to the classic version:

image

@brichet
Copy link
Contributor Author

brichet commented Jun 17, 2022

Thanks for the feedback @jhamrick, it should be fixed now

@jhamrick
Copy link
Member

Thanks!

@jhamrick jhamrick merged commit 5dbf8b9 into jupyter:main Jun 18, 2022
@brichet brichet deleted the labextension_style branch July 7, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants