-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check marking schemes for attachments to prevent leakage #1783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tuncbkose
c226517
to
ca07516
Compare
Not sure why the docs have failed |
Seems to be related to EDIT: I opened #1791 |
### BEGIN MARK SCHEME | ||
Text text text text text. | ||
![](attachment:image1.jpg) | ||
Grade grade grade. | ||
![](attachment:image2.png) | ||
Mark mark mark mark. | ||
### END MARK SCHEME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### BEGIN MARK SCHEME | |
Text text text text text. | |
![](attachment:image1.jpg) | |
Grade grade grade. | |
![](attachment:image2.png) | |
Mark mark mark mark. | |
### END MARK SCHEME | |
### BEGIN MARK SCHEME | |
Text text text text text. | |
![alternative text](attachment:image1.jpg) | |
Grade grade grade. | |
### END MARK SCHEME |
Thanks @tuncbkose, I was more thinking about alternative text to the image, to test the regular expression.
But if you think it is relevant to keep also a test with 2 images inserted we can also keep it (maybe keeping text around is also a good thing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. I'll add one with an alternative text. As for this example with two attachments and text around them, I don't think it matters too much but it doesn't hurt to keep it.
ca07516
to
3d98918
Compare
Failures are not related. Thanks @tuncbkose |
Fixes #1782.
The problem of adding images to marking schemes remains unsolved.