Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dependency to setuptools #1849

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Nov 30, 2023

Fix #1838

This PR adds a dependency to setuptools.

setuptools should normally be installed as a dependency of babel, itself a dependency of jupyterlab_server.

Nevertheless, it seems that some version of babel do not have this explicit dependency (e.g. babel==2.10), which can lead to instable installation of nbgrader.

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/nbgrader/setuptools_dependency

@brichet brichet added dependencies Python dependencies maintenance labels Nov 30, 2023
@brichet brichet merged commit 8f74964 into jupyter:main Nov 30, 2023
25 of 27 checks passed
@brichet brichet deleted the setuptools_dependency branch November 30, 2023 16:12
shreve pushed a commit to shreve/nbgrader that referenced this pull request Jul 8, 2024
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Python dependencies maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setuptools missing in dependencies
1 participant