Speed up tests #464
Merged
Speed up tests #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. How much faster? |
|
About twice as fast for the python tests (which means 4-5 minutes faster!) |
|
Whoa! Nicely done. Does this mean you get all difficult projects done in 5 hours, @jhamrick? ;) |
|
Haha, this took me a lot longer than 5 hours :-) |
|
Remeber:
Assuming 5min daily. You could have spend a week on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463 by having tests create nbgrader apps in the same python session rather than calling out to subprocess. This was a little tricky to do because it involved a lot of monkeypatching of things like sys.stdout, but ultimately I think I have gotten it to work correctly!