Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing windows tests #510

Merged
merged 11 commits into from
Jun 23, 2016
Merged

Fix failing windows tests #510

merged 11 commits into from
Jun 23, 2016

Conversation

jhamrick
Copy link
Member

Fixes #479, yay! 🎉

@willingc
Copy link
Member

willingc commented May 5, 2016

@jhamrick Any reason not to merge this now?

@jhamrick
Copy link
Member Author

jhamrick commented May 5, 2016

Because the tests still aren't passing on Jenkins :-(

@willingc
Copy link
Member

willingc commented May 5, 2016

Perhaps merge this and then work on the Windows and Jenkins issue independently.

@jhamrick
Copy link
Member Author

The windows tests are finally all passing for reals, hurray! Merging as soon as travis is happy 🎉

@willingc
Copy link
Member

oooh... nicely done @jhamrick

@willingc
Copy link
Member

So did you set the cookies-file to dev/null to just disable it

@jhamrick
Copy link
Member Author

Yes. I still don't exactly know why it's a problem with the nbextensions tests and not the formgrader tests (maybe just a race condition?) but it seems to work now so I'm going to leave it at that :-)

@willingc
Copy link
Member

Or perhaps it's just nbextensions... either way your plan to just go with seems good. How's UK?

@jhamrick
Copy link
Member Author

Yeah, I figure especially since it's just something in the test logic rather than nbgrader itself it doesn't matter too much as long as the tests pass.

The UK is awesome! London is such a cool city :-) How's California?

@willingc
Copy link
Member

California is hot. Enjoying working with the summer interns who you will meet at SciPy. See you there 😄

@jhamrick
Copy link
Member Author

Yes, looking forward to it! :-)

@jhamrick jhamrick merged commit 8f02221 into jupyter:master Jun 23, 2016
@jhamrick jhamrick deleted the windows branch June 23, 2016 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants