-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing windows tests #510
Conversation
@jhamrick Any reason not to merge this now? |
Because the tests still aren't passing on Jenkins :-( |
Perhaps merge this and then work on the Windows and Jenkins issue independently. |
The windows tests are finally all passing for reals, hurray! Merging as soon as travis is happy 🎉 |
oooh... nicely done @jhamrick |
So did you set the cookies-file to dev/null to just disable it |
Yes. I still don't exactly know why it's a problem with the nbextensions tests and not the formgrader tests (maybe just a race condition?) but it seems to work now so I'm going to leave it at that :-) |
Or perhaps it's just nbextensions... either way your plan to just go with seems good. How's UK? |
Yeah, I figure especially since it's just something in the test logic rather than nbgrader itself it doesn't matter too much as long as the tests pass. The UK is awesome! London is such a cool city :-) How's California? |
California is hot. Enjoying working with the summer interns who you will meet at SciPy. See you there 😄 |
Yes, looking forward to it! :-) |
Fixes #479, yay! 🎉