Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using javascript magic is potentially dangerous from within nbviewer #696

Closed
mpacer opened this issue May 18, 2017 · 3 comments
Closed

Using javascript magic is potentially dangerous from within nbviewer #696

mpacer opened this issue May 18, 2017 · 3 comments

Comments

@mpacer
Copy link
Member

mpacer commented May 18, 2017

If you go to this notebook from the IPython docs, you will see that it triggers two alerts. This seems inadvisable as it would be a opportunity for malicious notebooks to inject general javascript into viewers' browsers. Maybe, I'm overly worried, but it seems like we should write a preprocessor to make sure that this doesn't occur.

@rgbkrk @minrk

@rgbkrk
Copy link
Member

rgbkrk commented May 18, 2017

We generally assume that nbviewer is an unsafe place, which is why/how Bokeh and other display themselves on the page.

@rgbkrk
Copy link
Member

rgbkrk commented May 18, 2017

Long term view, I'd prefer all HTML and JS mimetype output to be iframed.

@mpacer mpacer closed this as completed May 19, 2017
@kiwi0fruit
Copy link

@mpacer How bad is this for the one who views the notebook? (At the moment I'm investigating this use case for nbviewer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants