Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra white inner border and stub toolbar in terminal #6787

Closed
JasonWeill opened this issue Mar 22, 2023 · 3 comments · Fixed by #6791
Closed

Extra white inner border and stub toolbar in terminal #6787

JasonWeill opened this issue Mar 22, 2023 · 3 comments · Fixed by #6791
Labels
bug status:Needs Triage Applied to issues that need triage

Comments

@JasonWeill
Copy link
Collaborator

In Notebook 7.0.0a17, the terminal has extra white inner border in light mode and white stub toolbar at the top. There is more space between the black rectangle and the bottom of the page than for the text editor, but maybe we need a bit more - but that spacing should match for the editor and terminal.

This was found by @ellisonbg during a bug bash.

Screen Shot 2023-03-20 at 3 34 57 PM

@JasonWeill JasonWeill added the bug label Mar 22, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 22, 2023
@JasonWeill
Copy link
Collaborator Author

In source (tip of master), I see the stub toolbar at the top, but not the inner white border. I'm using the default light border for Notebook, with a dark Terminal Theme.

image

@jtpio
Copy link
Member

jtpio commented Mar 23, 2023

That white inner white border looks unfamiliar (never seen it so far).

@ellisonbg
Copy link
Contributor

ellisonbg commented Mar 23, 2023 via email

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants